chore: Temporarily ignore advisory#27676
Merged
Gudahtt merged 1 commit intoVersion-v12.4.0from Oct 8, 2024
Merged
Conversation
The advisory GHSA-593m-55hh-j8gv has been temporarily ignored, just for v12.4.x. This is resolved by a dependency update in v12.5.0, but the update included too many functional changes, so we deemed it too risky to backport in this release. The impact is expected to be negligable due to our use of LavaMoat and SES lockdown.
7f8938d to
63509c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.4.0 #27676 +/- ##
================================================
Coverage 70.06% 70.06%
================================================
Files 1422 1422
Lines 49693 49693
Branches 13892 13892
================================================
Hits 34815 34815
Misses 14878 14878 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [63509c9]
Page Load Metrics (1779 ± 75 ms)
|
darkwing
approved these changes
Oct 8, 2024
matthewwalsh0
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The advisory GHSA-593m-55hh-j8gv has been temporarily ignored, just for v12.4.x. This is resolved by a dependency update in v12.5.0, but the update included too many functional changes, so we deemed it too risky to backport in this release.
The impact is expected to be negligable due to our use of LavaMoat and SES lockdown.
Related issues
The audit advisory was resolved here on
develop: #27620And it was back ported to v12.5.0 here: #27673
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist