Skip to content

chore: fix deps audit (#27620)#27673

Merged
Gudahtt merged 1 commit intoVersion-v12.5.0from
cherry-pick/fix-audit-advisory
Oct 7, 2024
Merged

chore: fix deps audit (#27620)#27673
Gudahtt merged 1 commit intoVersion-v12.5.0from
cherry-pick/fix-audit-advisory

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Oct 7, 2024

This is a cherry-pick of #27620 for v12.5.0. This PR resolves a security advisory by updating the @sentry/browser package.

Original description:

Description

Resolve the security advisory causing the audit CI job to fail by updating the @sentry/browser package.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27620?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Gudahtt Gudahtt marked this pull request as ready for review October 7, 2024 16:56
@Gudahtt Gudahtt requested review from a team as code owners October 7, 2024 16:56
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 7, 2024

@Gudahtt Gudahtt mentioned this pull request Oct 7, 2024
7 tasks
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [175935a]
Page Load Metrics (1931 ± 112 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37226411860421202
domContentLoaded151623481886220106
load152724681931233112
domInteractive17471599546
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 180 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -60.04 KiB (-0.74%)

@Gudahtt Gudahtt merged commit ff84f84 into Version-v12.5.0 Oct 7, 2024
@Gudahtt Gudahtt deleted the cherry-pick/fix-audit-advisory branch October 7, 2024 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Oct 21, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.5.0 on PR, as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.5.0 Issue or pull request that will be included in release 12.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants