Skip to content

fix: issue with default nonce value being wrong when switching networks between transactions#27634

Merged
danjm merged 1 commit intoVersion-v12.4.0from
Version-v12.4.0_nonce_fix
Oct 8, 2024
Merged

fix: issue with default nonce value being wrong when switching networks between transactions#27634
danjm merged 1 commit intoVersion-v12.4.0from
Version-v12.4.0_nonce_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Oct 4, 2024 •
edited
Loading

Description

Nonce in state should be reset correctly when switching between different networks.
The issue is already fixed in develop by PR: #27297

Related issues

Fixes: #27657

Manual testing steps

  1. Connect to Arbitrum
  2. Submit transaction with the high nonce
  3. Observe it fails with Internal JSON RPC error
  4. Switch to BNB Chain
  5. Start a transaction
  6. Transaction is created with correct nonce

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner October 4, 2024 15:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 4, 2024
@jpuri jpuri added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Oct 4, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 4, 2024

Builds ready [9ce4abb]
Page Load Metrics (1838 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27525541690509244
domContentLoaded156124981812213102
load156925651838224108
domInteractive15367568340

@danjm danjm merged commit 9446efa into Version-v12.4.0 Oct 8, 2024
@danjm danjm deleted the Version-v12.4.0_nonce_fix branch October 8, 2024 16:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpuri @metamaskbot @matthewwalsh0 @vinistevam @danjm