fix: issue with default nonce value being wrong when switching networks between transactions#27297
Conversation
…s between transactions
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [3a522b7]
Page Load Metrics (2208 ± 324 ms)
Bundle size diffs
|
Contributor
|
Build from #27297 (comment)
lineaSepolia.mov |
matthewwalsh0
previously approved these changes
Sep 23, 2024
| rejectPendingApproval(currentConfirmation.id, serializeError(error)), | ||
| ); | ||
| dispatch(updateCustomNonce('')); | ||
| dispatch(setNextNonce('')); |
Member
There was a problem hiding this comment.
Not needed now and not introduced by this PR, but perhaps a future refactor could be to remove the nonce from Redux completely and instead just store the custom nonce directly in the TransactionMeta, or let the TransactionController derive it if not specified.
|
Collaborator
Builds ready [8aa0342]
Page Load Metrics (1933 ± 123 ms)
Bundle size diffs
|
Collaborator
Builds ready [622bd6f]
Page Load Metrics (2221 ± 216 ms)
Bundle size diffs
|
Contributor
|
Fixed: nonce.mov |
pedronfigueiredo
approved these changes
Sep 24, 2024
digiwand
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When submitting transactions the transaction after network switch takes custom nonce of previous network.
Related issues
Fixes: #26979
Manual testing steps
Screenshots/Recordings
TODO
Pre-merge author checklist
Pre-merge reviewer checklist