Skip to content

fix (cherry-pick): disable transaction data decode if deployment (#27586)#27633

Merged
matthewwalsh0 merged 1 commit intoVersion-v12.4.0from
fix/cherry-pick-27524-disable-decode-deploy
Oct 4, 2024
Merged

fix (cherry-pick): disable transaction data decode if deployment (#27586)#27633
matthewwalsh0 merged 1 commit intoVersion-v12.4.0from
fix/cherry-pick-27524-disable-decode-deploy

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Oct 4, 2024 •
edited by github-actions bot
Loading

Description

Cherry-pick of #27586 for Version 12.4.0.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Oct 4, 2024
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner October 4, 2024 15:45
@matthewwalsh0 matthewwalsh0 merged commit 9a18f1c into Version-v12.4.0 Oct 4, 2024
@matthewwalsh0 matthewwalsh0 deleted the fix/cherry-pick-27524-disable-decode-deploy branch October 4, 2024 16:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 4, 2024

Builds ready [e0947b2]
Page Load Metrics (1842 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21724271681458220
domContentLoaded15802413181320398
load15912423184220297
domInteractive16173463517

@vinistevam vinistevam added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cryptotavares cryptotavares cryptotavares approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthewwalsh0 @metamaskbot @cryptotavares @vinistevam