Skip to content

fix: disable transaction data decode if deployment#27586

Merged
matthewwalsh0 merged 4 commits intodevelopfrom
fix/27524-disable-decode-deploy
Oct 4, 2024
Merged

fix: disable transaction data decode if deployment#27586
matthewwalsh0 merged 4 commits intodevelopfrom
fix/27524-disable-decode-deploy

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Oct 2, 2024 •
edited by github-actions bot
Loading

Description

Disable transaction data decoding when deploying a smart contract.

Open in GitHub Codespaces

Related issues

Fixes: #27524

Manual testing steps

See issue.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Oct 2, 2024
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner October 2, 2024 20:14
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 2, 2024

Builds ready [e148e1e]
Page Load Metrics (1965 ± 126 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint157925181951258124
domContentLoaded157024841922246118
load157925301965262126
domInteractive24159453014
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 350 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

vinistevam
vinistevam previously approved these changes Oct 3, 2024
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 3, 2024

Builds ready [84e421c]
Page Load Metrics (1798 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33023341739353170
domContentLoaded16122232177112761
load16192279179814067
domInteractive277140136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 350 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 3, 2024

Builds ready [efbf3c7]
Page Load Metrics (1883 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28321881789389187
domContentLoaded154423821856208100
load155223891883215103
domInteractive167740168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 350 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sleepytanya
Copy link
Copy Markdown
Contributor

sleepytanya commented Oct 4, 2024

Transaction data decoding is disabled when deploying smart contracts:

1.mov
2.mov
Screenshot 2024-10-03 at 23 53 43

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Oct 4, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 4, 2024

Builds ready [41e9cc2]
Page Load Metrics (1931 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint166326171929246118
domContentLoaded165226041905246118
load169926181931246118
domInteractive2497482210
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 350 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit 3bdb7eb Oct 4, 2024
@matthewwalsh0 matthewwalsh0 deleted the fix/27524-disable-decode-deploy branch October 4, 2024 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
@metamaskbot metamaskbot added release-12.7.0 Issue or pull request that will be included in release 12.7.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 4, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 7, 2024

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.7.0), as PR was cherry-picked in branch 12.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

QA Passed release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Contract Deployment - When I deploy a contract I see the At Inversebrah value as method in the new redesigned screen

5 participants

@matthewwalsh0 @metamaskbot @sleepytanya @pedronfigueiredo @vinistevam