fix (cherry-pick): incomplete transactions on startup (#26963) by vinistevam · Pull Request #27537 · MetaMask/metamask-extension

vinistevam · 2024-10-01T13:06:52Z

Description

This PR cherry-picks #26963

Related issues

Fixes: #27486

Manual testing steps

Started a tx
Disable the wallet from the chrome://extensions site
Enable it again
Try to Reject the tx
Tx unapproved disappears

Screenshots/Recordings

clean-unapproved-tx.webm

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Upgrade the `TransactionController` to `37.0.0`. Prevent various scenarios triggering the `signed or submitted` alert . Remove unapproved transaction fixtures as no longer supported.

github-actions · 2024-10-01T13:07:05Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-10-01T13:07:58Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/transaction-controller@37.0.0	network	`0`	2.1 MB	metamaskbot

🚮 Removed packages: npm/@metamask/transaction-controller@35.2.0

View full report↗︎

vinistevam · 2024-10-01T13:38:51Z

@metamaskbot update-policies

metamaskbot · 2024-10-01T13:50:58Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

codecov · 2024-10-01T15:21:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.05%. Comparing base (bc08781) to head (c942cc0).

Additional details and impacted files

@@               Coverage Diff                @@
##           Version-v12.4.0   #27537   +/-   ##
================================================
  Coverage            70.05%   70.05%           
================================================
  Files                 1422     1422           
  Lines                49677    49677           
  Branches             13887    13887           
================================================
  Hits                 34800    34800           
  Misses               14877    14877

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-10-01T15:33:46Z

Builds ready [ba77578]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1665 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1406	2312	1670	199	96
		domContentLoaded	1398	2218	1646	188	90
		load	1406	2245	1665	191	92
		domInteractive	16	188	39	36	17

…saction-controller-startup

metamaskbot · 2024-10-01T18:26:20Z

Builds ready [c942cc0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1683 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1512	1963	1691	110	53
		domContentLoaded	1503	1923	1662	103	50
		load	1512	1968	1683	110	53
		domInteractive	12	137	30	27	13

…saction-controller-startup

fix: incomplete transactions on startup (#26963)

b2fa352

Upgrade the `TransactionController` to `37.0.0`. Prevent various scenarios triggering the `signed or submitted` alert . Remove unapproved transaction fixtures as no longer supported.

github-actions bot added the team-confirmations Push issues to confirmations team label Oct 1, 2024

fix yarn.lock and unit tests

2cedf71

vinistevam force-pushed the cherry-pick-12.4.0-fix-23361-transaction-controller-startup branch from 396c68c to 2cedf71 Compare October 1, 2024 13:27

Update LavaMoat policies

224ce27

vinistevam changed the title ~~fix: cherry pick fix 23361 transaction controller startup~~ fix: cherry pick incomplete transactions on startup Oct 1, 2024

vinistevam force-pushed the cherry-pick-12.4.0-fix-23361-transaction-controller-startup branch from 3a51546 to fb5b3d5 Compare October 1, 2024 14:03

fix merge conflicts

ba77578

vinistevam force-pushed the cherry-pick-12.4.0-fix-23361-transaction-controller-startup branch from fb5b3d5 to ba77578 Compare October 1, 2024 15:01

Merge branch 'Version-v12.4.0' into cherry-pick-12.4.0-fix-23361-tran…

c942cc0

…saction-controller-startup

vinistevam marked this pull request as ready for review October 1, 2024 17:51

vinistevam requested a review from a team as a code owner October 1, 2024 17:51

OGPoyraz approved these changes Oct 2, 2024

View reviewed changes

pedronfigueiredo approved these changes Oct 3, 2024

View reviewed changes

Merge branch 'Version-v12.4.0' into cherry-pick-12.4.0-fix-23361-tran…

f67fe8a

…saction-controller-startup

danjm merged commit f072921 into Version-v12.4.0 Oct 3, 2024

danjm deleted the cherry-pick-12.4.0-fix-23361-transaction-controller-startup branch October 3, 2024 15:37

github-actions bot locked and limited conversation to collaborators Oct 3, 2024

vinistevam added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Oct 7, 2024

vinistevam changed the title ~~fix: cherry pick incomplete transactions on startup~~ fix (cherry-pick): incomplete transactions on startup (https://github.com/MetaMask/metamask-extension/pull/26963) Oct 7, 2024

vinistevam changed the title ~~fix (cherry-pick): incomplete transactions on startup (https://github.com/MetaMask/metamask-extension/pull/26963)~~ fix (cherry-pick): incomplete transactions on startup https://github.com/MetaMask/metamask-extension/pull/26963 Oct 7, 2024

vinistevam changed the title ~~fix (cherry-pick): incomplete transactions on startup https://github.com/MetaMask/metamask-extension/pull/26963~~ fix (cherry-pick): incomplete transactions on startup (#26963) Oct 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix (cherry-pick): incomplete transactions on startup (#26963)#27537

fix (cherry-pick): incomplete transactions on startup (#26963)#27537
danjm merged 6 commits intoVersion-v12.4.0from
cherry-pick-12.4.0-fix-23361-transaction-controller-startup

vinistevam commented Oct 1, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 1, 2024

Uh oh!

socket-security bot commented Oct 1, 2024 •

edited

Loading

Uh oh!

vinistevam commented Oct 1, 2024

Uh oh!

metamaskbot commented Oct 1, 2024

Uh oh!

codecov bot commented Oct 1, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Oct 1, 2024

Uh oh!

metamaskbot commented Oct 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

vinistevam commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 1, 2024

Uh oh!

socket-security bot commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinistevam commented Oct 1, 2024

Uh oh!

metamaskbot commented Oct 1, 2024

Uh oh!

codecov bot commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Oct 1, 2024

Uh oh!

metamaskbot commented Oct 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vinistevam commented Oct 1, 2024 •

edited

Loading

socket-security bot commented Oct 1, 2024 •

edited

Loading

codecov bot commented Oct 1, 2024 •

edited

Loading