fix: incomplete transactions on startup by matthewwalsh0 · Pull Request #26963 · MetaMask/metamask-extension

matthewwalsh0 · 2024-09-06T10:12:14Z

Description

Upgrade the TransactionController to prevent various scenarios triggering the signed or submitted alert and blocking subsequent transactions.

Related issues

Fixes: #23361

Manual testing steps

Basic regression of transaction functionality.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2024-09-06T10:13:01Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/transaction-controller@37.0.0	network	`0`	2.1 MB	metamaskbot

🚮 Removed packages: npm/@metamask/base-controller@7.0.0, npm/@metamask/controller-utils@11.2.0, npm/@metamask/transaction-controller@35.2.0

View full report↗︎

metamaskbot · 2024-09-10T18:19:16Z

Builds ready [bc81945]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1851 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	219	2355	1677	497	239
		domContentLoaded	1595	2304	1826	176	84
		load	1605	2351	1851	187	90
		domInteractive	13	87	40	21	10

sleepytanya · 2024-09-11T00:50:42Z

Basic transactions functionality: cancel, speed up, custom nonce, transactions history, contract interactions, approvals, navigation between multiple transactions, gas settings, PPOM - passed

STX fail with the error:

sleepytanya · 2024-09-11T20:07:44Z

@matthewwalsh0

STX work on develop commit a61b938

stxDevelop.mov

sleepytanya · 2024-09-13T17:07:10Z

@matthewwalsh0
Oh, I know where the problem is #26979
And great news that it is not related to this PR as this is current behavior on develop

codecov · 2024-09-14T01:50:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.01%. Comparing base (67cf369) to head (85b6fc1).
Report is 7 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26963      +/-   ##
===========================================
+ Coverage    69.96%   70.01%   +0.05%     
===========================================
  Files         1441     1445       +4     
  Lines        50108    50192      +84     
  Branches     14012    14041      +29     
===========================================
+ Hits         35054    35137      +83     
- Misses       15054    15055       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-09-14T02:01:57Z

Builds ready [b9085c7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1691 ± 98 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1486	2544	1693	217	104
		domContentLoaded	1478	2461	1672	203	97
		load	1488	2475	1691	204	98
		domInteractive	13	58	35	13	6

Bundle size diffs [🚀 Bundle size reduced!]

background: -32 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: -12.83 KiB (-0.16%)

socket-security · 2024-09-17T10:03:47Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

sonarqubecloud · 2024-09-17T10:24:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-17T11:00:54Z

Builds ready [85b6fc1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1638 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	227	2281	1578	358	172
		domContentLoaded	1444	2115	1620	151	73
		load	1452	2196	1638	169	81
		domInteractive	14	98	41	20	10

Bundle size diffs [🚀 Bundle size reduced!]

background: 53 Bytes (0.00%)
ui: 45 Bytes (0.00%)
common: -15.16 KiB (-0.19%)

Upgrade transaction controller

bcab730

matthewwalsh0 added the team-confirmations Push issues to confirmations team label Sep 6, 2024

matthewwalsh0 requested review from a team as code owners September 6, 2024 10:12

matthewwalsh0 added 4 commits September 10, 2024 00:55

Fix E2E tests

f0b5c85

Fix linting

9cab13b

Merge branch 'develop' into fix/23361-transaction-controller-startup

feaa3b3

Fix Firefox E2E tests

bc81945

pedronfigueiredo previously approved these changes Sep 12, 2024

View reviewed changes

sleepytanya added the QA Passed label Sep 13, 2024

Merge branch 'develop' into fix/23361-transaction-controller-startup

b9085c7

matthewwalsh0 dismissed pedronfigueiredo’s stale review via b9085c7 September 14, 2024 01:23

matthewwalsh0 added 6 commits September 16, 2024 15:38

Update package version

3bc5ec4

Merge branch 'develop' into fix/23361-transaction-controller-startup

2a28415

Merge branch 'develop' into fix/23361-transaction-controller-startup

f4797ba

Merge branch 'develop' into fix/23361-transaction-controller-startup

e6303ae

Fix unit test

4f05eb3

Fix storybook

ebc5a8a

matthewwalsh0 added 2 commits September 17, 2024 11:09

Revert Yarn lock

3d9a630

Fix unit tests

85b6fc1

pedronfigueiredo approved these changes Sep 17, 2024

View reviewed changes

OGPoyraz approved these changes Sep 17, 2024

View reviewed changes

matthewwalsh0 merged commit 39c75a8 into develop Sep 17, 2024

matthewwalsh0 deleted the fix/23361-transaction-controller-startup branch September 17, 2024 10:56

github-actions bot locked and limited conversation to collaborators Sep 17, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 17, 2024

metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: incomplete transactions on startup#26963

fix: incomplete transactions on startup#26963
matthewwalsh0 merged 14 commits intodevelopfrom
fix/23361-transaction-controller-startup

matthewwalsh0 commented Sep 6, 2024 •

edited by github-actions bot

Loading

Uh oh!

socket-security bot commented Sep 6, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Sep 10, 2024

Uh oh!

sleepytanya commented Sep 11, 2024

Uh oh!

sleepytanya commented Sep 11, 2024

Uh oh!

sleepytanya commented Sep 13, 2024

Uh oh!

codecov bot commented Sep 14, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Sep 14, 2024

Uh oh!

socket-security bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Sep 17, 2024

Uh oh!

metamaskbot commented Sep 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

matthewwalsh0 commented Sep 6, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security bot commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Sep 10, 2024

Uh oh!

sleepytanya commented Sep 11, 2024

Uh oh!

sleepytanya commented Sep 11, 2024

Uh oh!

sleepytanya commented Sep 13, 2024

Uh oh!

codecov bot commented Sep 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Sep 14, 2024

Uh oh!

socket-security bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 17, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Sep 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

matthewwalsh0 commented Sep 6, 2024 •

edited by github-actions bot

Loading

socket-security bot commented Sep 6, 2024 •

edited

Loading

codecov bot commented Sep 14, 2024 •

edited

Loading

socket-security bot commented Sep 17, 2024 •

edited

Loading