Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [d641d06]
Page Load Metrics (1736 ± 104 ms)
Bundle size diffs
|
gambinish
approved these changes
Sep 27, 2024
Member
gambinish
left a comment
There was a problem hiding this comment.
Thanks for this! I am linking our slack conversation here for tracking purposes: https://consensys.slack.com/archives/C03ETQA9EPK/p1727373903173259
gambinish
added a commit
that referenced
this pull request
Sep 27, 2024
darkwing
approved these changes
Sep 27, 2024
7 tasks
|
Collaborator
Builds ready [7d78d3c]
Page Load Metrics (1793 ± 68 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR fixes:
test/e2e/tests/confirmations/signatures/permit.spec.tsIssue was that e2e were passing in CI, but failing locally. The changes here provide a few helpers to prevent this flakey behavior.
The issue was first flagged here: #27184 (comment)
Follow up slack thread here: https://consensys.slack.com/archives/C03ETQA9EPK/p1727373903173259
Related issues
Fixes:
test/e2e/tests/confirmations/signatures/permit.spec.tswhen running chrome e2e locallyManual testing steps
permit.spec.tsshould pass e2e chrome locally and in CIScreenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist