fix: Change speed key color#27416
Merged
pedronfigueiredo merged 2 commits intodevelopfrom Sep 26, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
previously approved these changes
Sep 26, 2024
digiwand
previously requested changes
Sep 26, 2024
Contributor
digiwand
left a comment
There was a problem hiding this comment.
hi @pedronfigueiredo, nice fix! This PR does require snapshot updates
ui/pages/confirmations/components/confirm/info/set-approval-for-all-info/set-approval-for-all-info.test.tsx
Contributor
|
plus 1 lint error has appeared
|
Collaborator
Builds ready [289c1da]
Page Load Metrics (2218 ± 242 ms)
Bundle size diffs
|
289c1da to
ff65152
Compare
|
Collaborator
Builds ready [ff65152]
Page Load Metrics (1693 ± 94 ms)
Bundle size diffs
|
jpuri
approved these changes
Sep 26, 2024
vinistevam
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of #26986, the wrapper component for "Speed" was changed from ConfirmInfoRow to ConfirmInfoAlertRow. This change means that the
ConfirmInfoRowVariant.Defaultapplied to this component changes the color to blue.To revert that aesthetic change, this PR removes said variant.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist