Skip to content

test: add integration test for pending transaction alert and fix bug …#26986

Merged
pnarayanaswamy merged 4 commits intodevelopfrom
pending-transactions-it
Sep 9, 2024
Merged

test: add integration test for pending transaction alert and fix bug …#26986
pnarayanaswamy merged 4 commits intodevelopfrom
pending-transactions-it

Conversation

@pnarayanaswamy
Copy link
Copy Markdown
Contributor

@pnarayanaswamy pnarayanaswamy commented Sep 9, 2024 •
edited by github-actions bot
Loading

…of error not showing

Description

Fixes issue that the pending transaction alert is not displayed
Adds an integration test to verify pending transaction alert is displayed

Open in GitHub Codespaces

Related issues

Fixes: 2974

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy requested review from a team as code owners September 9, 2024 10:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Sep 9, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 9, 2024

Builds ready [5fe0af9]
Page Load Metrics (1616 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25621381550342164
domContentLoaded13942042159215876
load14532139161616881
domInteractive12190404019
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 494 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (416d024) to head (2c09ed7).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26986      +/-   ##
===========================================
+ Coverage    70.17%   70.18%   +0.01%     
===========================================
  Files         1425     1425              
  Lines        49659    49659              
  Branches     13891    13891              
===========================================
+ Hits         34846    34849       +3     
+ Misses       14813    14810       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 9, 2024

Builds ready [2c09ed7]
Page Load Metrics (1628 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46220401578291140
domContentLoaded14541854160611756
load14621926162812560
domInteractive12144342814
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 494 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@pnarayanaswamy pnarayanaswamy merged commit 739d1df into develop Sep 9, 2024
@pnarayanaswamy pnarayanaswamy deleted the pending-transactions-it branch September 9, 2024 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 9, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees

No one assigned

Labels

release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pnarayanaswamy @metamaskbot @jpuri @pedronfigueiredo @gauthierpetetin