feat: cross chain swaps - tx submit#27262
Merged
infiniteflower merged 93 commits intodevelopfrom Nov 21, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
325a70a to
a6d627c
Compare
448ce2a to
4971d09
Compare
b433f88 to
2813f63
Compare
4971d09 to
52f9352
Compare
infiniteflower
added a commit
to MetaMask/core
that referenced
this pull request
Oct 3, 2024
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> This PR adds additional types to facilitate Bridge development in Extension. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? For example: * Fixes #12345 * Related to #67890 --> Related to: MetaMask/metamask-extension#27262 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/transaction-controller` - ADDED: `bridgeApproval`, `bridge` types ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
3c283a7 to
94365a1
Compare
1ee57c2 to
81fbdf1
Compare
a37617b to
1d686bd
Compare
9f11057 to
7c2f8e0
Compare
b0e3d32 to
d2d1d5a
Compare
7c2f8e0 to
3222e6d
Compare
3222e6d to
6506bef
Compare
d2d1d5a to
6de5ea4
Compare
d80b1c6 to
75afeab
Compare
micaelae
reviewed
Oct 10, 2024
78bcf71 to
403d594
Compare
…sLimit is inclusive of them already
This reverts commit c2715c6.
Collaborator
Builds ready [496fa98]
Page Load Metrics (2139 ± 91 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
approved these changes
Nov 20, 2024
Member
There was a problem hiding this comment.
Minor, I love these modular hooks, but a benefit of having them in separate files is to be able to test them individually also.
| if (networkAndAccountSupports1559) { | ||
| const { estimatedBaseFeeGwei = '0' } = networkGasFeeEstimates; | ||
| const hexEstimatedBaseFee = decGWEIToHexWEI(estimatedBaseFeeGwei) as Hex; | ||
| const txGasFeeEstimates = await getTransaction1559GasFeeEstimates( |
micaelae
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following:
Does not fully:
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2024-11-08.at.11.06.12.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist