Skip to content

chore: Bump storybook, @storybook/* to ^7.6.20, storybook-dark-mode from ^3.0.3 to ^4.0.2#26703

Merged
legobeat merged 2 commits intoMetaMask:developfrom
legobeat:devdeps-storybook-202408
Aug 29, 2024
Merged

chore: Bump storybook, @storybook/* to ^7.6.20, storybook-dark-mode from ^3.0.3 to ^4.0.2#26703
legobeat merged 2 commits intoMetaMask:developfrom
legobeat:devdeps-storybook-202408

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Aug 28, 2024 •
edited
Loading

Description

  • Bump storybook packages
  • Upgrade storybook-dark-mode from ^3.0.3 to ^4.0.2

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@legobeat legobeat added team-design-system All issues relating to design system in Extension team-wallet-framework team-application-security Application security team labels Aug 28, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Aug 28, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@storybook/addon-a11y@7.6.20 None 0 43.3 kB valentinpalkovic
npm/@storybook/addon-backgrounds@7.6.20 None 0 13.5 kB valentinpalkovic
npm/@storybook/addon-controls@7.6.20 None 0 12.6 kB valentinpalkovic
npm/@storybook/addon-essentials@7.6.20 None 0 9.39 kB valentinpalkovic
npm/@storybook/addon-highlight@7.6.20 None 0 8.43 kB valentinpalkovic
npm/@storybook/addon-mdx-gfm@7.6.20 None 0 3.42 kB valentinpalkovic
npm/@storybook/addon-measure@7.6.20 None 0 18.5 kB valentinpalkovic
npm/@storybook/addon-outline@7.6.20 None 0 14 kB valentinpalkovic
npm/@storybook/addon-toolbars@7.6.20 None 0 10.1 kB valentinpalkovic
npm/@storybook/addon-viewport@7.6.20 None 0 16.5 kB valentinpalkovic
npm/@storybook/addons@7.6.20 None 0 4.5 kB valentinpalkovic
npm/@storybook/api@7.6.20 None 0 2.69 kB valentinpalkovic
npm/@storybook/builder-manager@7.6.20 filesystem 0 115 kB valentinpalkovic
npm/@storybook/builder-webpack5@7.6.20 filesystem 0 148 kB valentinpalkovic
npm/@storybook/cli@7.6.20 environment, filesystem 0 1.36 MB valentinpalkovic
npm/@storybook/client-api@7.6.20 None 0 2.8 kB valentinpalkovic
npm/@storybook/codemod@7.6.20 filesystem 0 604 kB valentinpalkovic
npm/@storybook/core-server@7.6.20 filesystem 0 2.91 MB valentinpalkovic
npm/@storybook/core-webpack@7.6.20 None 0 15.4 kB valentinpalkovic
npm/@storybook/icons@1.2.10 None 0 1.19 MB ndelangen
npm/@storybook/manager@7.6.20 None 0 2.57 MB valentinpalkovic
npm/@storybook/preset-react-webpack@7.6.20 None 0 25.2 kB valentinpalkovic
npm/@storybook/preview@7.6.20 eval, network 0 365 kB valentinpalkovic
npm/@storybook/react-webpack5@7.6.20 None 0 98.6 kB valentinpalkovic
npm/@storybook/telemetry@7.6.20 environment, filesystem, network, shell 0 429 kB valentinpalkovic
npm/storybook-dark-mode@4.0.2 None 0 75.6 kB alisowski
npm/storybook@7.6.20 None 0 1.25 kB valentinpalkovic

🚮 Removed packages: npm/@storybook/addon-a11y@7.6.19), npm/@storybook/addon-backgrounds@7.6.19), npm/@storybook/addon-controls@7.6.19), npm/@storybook/addon-essentials@7.6.19), npm/@storybook/addon-highlight@7.6.19), npm/@storybook/addon-mdx-gfm@7.6.19), npm/@storybook/addon-measure@7.6.19), npm/@storybook/addon-outline@7.6.19), npm/@storybook/addon-toolbars@7.6.19), npm/@storybook/addon-viewport@7.6.19), npm/@storybook/addons@7.6.19), npm/@storybook/api@7.6.19), npm/@storybook/builder-manager@7.6.19), npm/@storybook/builder-webpack5@7.6.19), npm/@storybook/cli@7.6.19), npm/@storybook/client-api@7.6.19), npm/@storybook/codemod@7.6.19), npm/@storybook/core-server@7.6.19), npm/@storybook/core-webpack@7.6.19), npm/@storybook/manager@7.6.19), npm/@storybook/preset-react-webpack@7.6.19), npm/@storybook/preview@7.6.19), npm/@storybook/react-webpack5@7.6.19), npm/@storybook/telemetry@7.6.19), npm/storybook-dark-mode@3.0.3), npm/storybook@7.6.19)

View full report↗︎

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Aug 28, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Aug 28, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@storybook/addon-a11y@7.6.20, npm/@storybook/addon-backgrounds@7.6.20, npm/@storybook/addon-controls@7.6.20, npm/@storybook/addon-essentials@7.6.20, npm/@storybook/addon-highlight@7.6.20, npm/@storybook/addon-mdx-gfm@7.6.20, npm/@storybook/addon-measure@7.6.20, npm/@storybook/addon-outline@7.6.20, npm/@storybook/addon-toolbars@7.6.20, npm/@storybook/addon-viewport@7.6.20, npm/@storybook/addons@7.6.20, npm/@storybook/api@7.6.20, npm/@storybook/builder-manager@7.6.20, npm/@storybook/builder-webpack5@7.6.20, npm/@storybook/cli@7.6.20, npm/@storybook/client-api@7.6.20, npm/@storybook/codemod@7.6.20, npm/@storybook/core-server@7.6.20, npm/@storybook/core-webpack@7.6.20, npm/@storybook/manager@7.6.20, npm/@storybook/preset-react-webpack@7.6.20, npm/@storybook/preview@7.6.20, npm/@storybook/react-webpack5@7.6.20, npm/@storybook/telemetry@7.6.20, npm/storybook@7.6.20

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat changed the title Bump storybook, @storybook/* to ^7.6.20, storybook-dark-mode from ^3.0.3 to ^4.0.2 chore: Bump storybook, @storybook/* to ^7.6.20, storybook-dark-mode from ^3.0.3 to ^4.0.2 Aug 28, 2024
@legobeat legobeat mentioned this pull request Aug 28, 2024
Merged
8 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Aug 28, 2024 

@SocketSecurity ignore npm/@storybook/addon-toolbars@7.6.20
@SocketSecurity ignore npm/@storybook/preview@7.6.20
@SocketSecurity ignore npm/@storybook/manager@7.6.20
@SocketSecurity ignore npm/@storybook/addon-essentials@7.6.20
@SocketSecurity ignore npm/storybook@7.6.20
@SocketSecurity ignore npm/@storybook/addon-backgrounds@7.6.20
@SocketSecurity ignore npm/@storybook/addon-controls@7.6.20
@SocketSecurity ignore npm/@storybook/addon-highlight@7.6.20
@SocketSecurity ignore npm/@storybook/addon-measure@7.6.20
@SocketSecurity ignore npm/@storybook/addon-outline@7.6.20
@SocketSecurity ignore npm/@storybook/addon-viewport@7.6.20
@SocketSecurity ignore npm/@storybook/builder-webpack5@7.6.20
@SocketSecurity ignore npm/@storybook/preset-react-webpack@7.6.20
@SocketSecurity ignore npm/@storybook/core-webpack@7.6.20
@SocketSecurity ignore npm/@storybook/cli@7.6.20
@SocketSecurity ignore npm/@storybook/codemod@7.6.20
@SocketSecurity ignore npm/@storybook/core-server@7.6.20
@SocketSecurity ignore npm/@storybook/telemetry@7.6.20
@SocketSecurity ignore npm/@storybook/addon-a11y@7.6.20
@SocketSecurity ignore npm/@storybook/builder-manager@7.6.20
@SocketSecurity ignore npm/@storybook/react-webpack5@7.6.20
@SocketSecurity ignore npm/@storybook/addons@7.6.20
@SocketSecurity ignore npm/@storybook/api@7.6.20
@SocketSecurity ignore npm/@storybook/addon-mdx-gfm@7.6.20
@SocketSecurity ignore npm/@storybook/client-api@7.6.20

new authors ok

@legobeat legobeat marked this pull request as ready for review August 28, 2024 09:45
@legobeat legobeat requested review from a team as code owners August 28, 2024 09:45
@legobeat legobeat requested a review from MajorLift August 28, 2024 10:01
MajorLift
MajorLift approved these changes Aug 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! These changes have passed CI in the following PRs:

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (fb61b0f) to head (1b1687b).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26703   +/-   ##
========================================
  Coverage    70.08%   70.08%           
========================================
  Files         1413     1413           
  Lines        49318    49318           
  Branches     13780    13780           
========================================
  Hits         34562    34562           
  Misses       14756    14756

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desi desi requested review from a team August 28, 2024 15:34
@desi desi removed the team-design-system All issues relating to design system in Extension label Aug 28, 2024
metamaskbot and others added 2 commits August 29, 2024 12:05
@metamaskbot @MajorLift @legobeat
Bump storybook, @storybook/* to ^7.6.20, storybook-dark-mode …
bfe7439 
…from `^3.0.3` to `^4.0.2`

---------

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
@legobeat
chore: update lavamoat build policy
1b1687b
@legobeat legobeat force-pushed the devdeps-storybook-202408 branch from 844b168 to 1b1687b Compare August 29, 2024 03:05
garrettbear
garrettbear approved these changes Aug 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Screenshot 2024-08-29 at 9 07 37 AM

@legobeat legobeat merged commit 11f4a57 into MetaMask:develop Aug 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Sep 25, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 25, 2024

No release label on PR. Adding release label release-12.5.0 on PR, as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MajorLift MajorLift MajorLift approved these changes

+1 more reviewer

@garrettbear garrettbear garrettbear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-application-security Application security team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legobeat @metamaskbot @garrettbear @MajorLift @desi