cherry-pick(v12.1.1): Bump `@metamask/eth-json-rpc-middleware` to `^14.0.0` (#26143) by MajorLift · Pull Request #26626 · MetaMask/metamask-extension

MajorLift · 2024-08-22T18:39:05Z

Description

Cherry-pick of #26143 for ~~v12.1.0-rc~~ v12.1.1-rc.

This is a very different PR from the original, as I had to remove diffs to a significant amount of code that has not yet been introduced to the release candidate.

The diffs that were excluded here will need to be reapplied to a future release. I'm also keeping an eye out for new cherry-picks that may introduce changes requiring me to restore certain diffs.

Aligning @metamask/eth-block-tracker to ^11.0.1 is deferred, as it's blocked by #26150, which is not included in this release candidate. The @metamask/transaction-controller major version bump from ^34.0.0 to ^35.1.1 is also removed for now.

See below for new changelog.

Changelog

Added

Add and export PPOMMiddlewareRequest type for JsonRpcRequest types
that include the securityAlertResponse property.
- securityAlertResponse is defined as both optional and nullable.
Add PPOMRequest type for eth-sendTransaction requests.

Changed

BREAKING: Bump @metamask/eth-json-rpc-middleware from ^12.1.1
to ^14.0.0.
Bump @trezor/connect-web from 9.2.2 to 9.3.0.

Fixed

BREAKING: Narrow Params generic parameter of
createPPOMMiddleware function from JsonRpcParams to (string | { to: string })[].
Add Params generic parameter to handleSnapRequest function, which
is constrained by Record<string, unknown> and defaults to JsonRpcParams.
- handleSnapRequest can now be typed correctly with any params
  object.

Security

BREAKING: Typed signature validation only replaces 0X prefix
with 0x, and contract address normalization is removed for decimal and
octal values.
- Threat actors have been manipulating eth_signTypedData_v4 fields to
  cause failures in blockaid's detectors.
- Extension crashes with an error when performing Malicious permit with
  a non-0x prefixed integer address.
- This fixes an issue where the key value row or petname component
  disappears if a signed address is prefixed by "0X" instead of "0x".

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Gudahtt · 2024-08-22T20:56:36Z

We'll be targeting this for v12.1.1 instead, so I've temporarily labelled this as DO-NOT-MERGE until that RC is ready to target.

metamaskbot · 2024-08-22T21:29:24Z

Builds ready [44264fa]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (251 ± 259 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	128	103	16	8
		domContentLoaded	11	58	25	13	6
		load	50	2108	251	539	259
		domInteractive	11	58	25	13	6

codecov · 2024-08-22T21:29:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.84%. Comparing base (0ef30b9) to head (433c309).
Report is 1 commits behind head on Version-v12.1.1.

Additional details and impacted files

@@               Coverage Diff                @@
##           Version-v12.1.1   #26626   +/-   ##
================================================
  Coverage            69.84%   69.84%           
================================================
  Files                 1371     1371           
  Lines                48791    48795    +4     
  Branches             13453    13455    +2     
================================================
+ Hits                 34074    34078    +4     
  Misses               14717    14717

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yarn.lock

…from `^3.0.3` to `^4.0.2`

…es in `makeExpirySet`method

- Convert test/jest/mocks.js to TypeScript

MajorLift · 2024-08-30T15:52:53Z

@metamaskbot update-policies

metamaskbot · 2024-08-30T16:03:40Z

Policies updated

MajorLift · 2024-08-30T16:07:54Z

test/jest/mocks.ts

@@ -171,19 +176,28 @@ export const getInitialSendStateWithExistingTxState = (draftTxState) => ({
 });

 export function createMockInternalAccount({


I had to partially cherry-pick a commit in develop (#25980) that converts test/jest/mocks.js into TypeScript, because the params types of createMockInternalAccount were being incompletely inferred from the JavaScript code, causing conflicting type errors downstream. Supplying the correct type information in TypeScript was the only solution.

metamaskbot · 2024-08-30T16:54:12Z

Builds ready [9df53e5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (67 ± 21 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	341	97	57	28
		domContentLoaded	9	56	24	14	7
		load	41	248	67	44	21
		domInteractive	9	56	24	14	7

yarn.lock

Gudahtt

Mostly looks good! But I think we can trim down these lock file changes further

MajorLift · 2024-08-30T17:08:26Z

@metamaskbot update-policies

metamaskbot · 2024-08-30T17:19:23Z

Policies updated

Requested change has been made

Gudahtt

LGTM!

metamaskbot · 2024-08-30T17:56:41Z

Builds ready [433c309]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (243 ± 256 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	147	104	18	9
		domContentLoaded	10	53	22	12	6
		load	45	1875	243	533	256
		domInteractive	10	53	22	12	6

metamaskbot · 2024-08-30T17:57:12Z

Builds ready [433c309]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (243 ± 256 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	147	104	18	9
		domContentLoaded	10	53	22	12	6
		load	45	1875	243	533	256
		domInteractive	10	53	22	12	6

metamaskbot · 2024-09-03T15:06:47Z

No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0.

This comment was marked as resolved.

Sign in to view

metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-wallet-framework labels Aug 22, 2024

This comment was marked as outdated.

Sign in to view

MajorLift force-pushed the chore/cherry-pick-26143 branch from c4f5329 to 29d7f50 Compare August 22, 2024 19:00

This comment was marked as outdated.

Sign in to view

MajorLift force-pushed the chore/cherry-pick-26143 branch from 29d7f50 to 6498b33 Compare August 22, 2024 19:40

This comment was marked as outdated.

Sign in to view

MajorLift force-pushed the chore/cherry-pick-26143 branch from 77ae327 to d6d7ca3 Compare August 22, 2024 20:29

MajorLift marked this pull request as ready for review August 22, 2024 20:47

MajorLift requested review from a team as code owners August 22, 2024 20:47

MajorLift force-pushed the chore/cherry-pick-26143 branch from d6d7ca3 to 44264fa Compare August 22, 2024 20:51

Gudahtt added the DO-NOT-MERGE Pull requests that should not be merged label Aug 22, 2024

legobeat reviewed Aug 22, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

MajorLift force-pushed the chore/cherry-pick-26143 branch from f0d58d1 to 694db65 Compare August 23, 2024 17:57

MajorLift added 5 commits August 30, 2024 11:34

Bump storybook, @storybook/* to ^7.6.20, storybook-dark-mode …

7009221

…from `^3.0.3` to `^4.0.2`

Fix type-error regressions

8c8880f

Linter import sort fix

9229eef

Revert breaking change to createDupeReqFilterStream by updating typ…

14229d2

…es in `makeExpirySet`method

Partial cherry-pick 95f7753 (#25980)

b59c933

- Convert test/jest/mocks.js to TypeScript

MajorLift force-pushed the chore/cherry-pick-26143 branch from 267aa11 to b59c933 Compare August 30, 2024 15:44

Revert changes made to downgrade @metamask/keyring-api to 8.0.0

9e02d20

MajorLift mentioned this pull request Aug 30, 2024

fix: revert breaking change to requests with null ids (#26143) #26814

Merged

7 tasks

Update LavaMoat policies

9df53e5

MajorLift commented Aug 30, 2024

View reviewed changes

Gudahtt reviewed Aug 30, 2024

View reviewed changes

yarn.lock Show resolved Hide resolved

Gudahtt previously requested changes Aug 30, 2024

View reviewed changes

MajorLift added 2 commits August 30, 2024 13:05

Remove unnecessary diffs from yarn lockfile

6d45f37

Remove unused ts-expect-error directive

6a41dc4

Update LavaMoat policies

433c309

Gudahtt approved these changes Aug 30, 2024

View reviewed changes

MajorLift merged commit abe7da4 into Version-v12.1.1 Aug 30, 2024

MajorLift deleted the chore/cherry-pick-26143 branch August 30, 2024 17:57

github-actions bot locked and limited conversation to collaborators Aug 30, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 30, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Sep 3, 2024

		@@ -171,19 +176,28 @@ export const getInitialSendStateWithExistingTxState = (draftTxState) => ({
		});

		export function createMockInternalAccount({

Conversation

MajorLift commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Added

Changed

Fixed

Security

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Gudahtt commented Aug 22, 2024

Uh oh!

metamaskbot commented Aug 22, 2024

Uh oh!

codecov bot commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

This comment was marked as outdated.

MajorLift commented Aug 30, 2024

Uh oh!

metamaskbot commented Aug 30, 2024

Uh oh!

MajorLift Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Aug 30, 2024

Uh oh!

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

MajorLift commented Aug 30, 2024

Uh oh!

metamaskbot commented Aug 30, 2024

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Aug 30, 2024

Uh oh!

metamaskbot commented Aug 30, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MajorLift commented Aug 22, 2024 •

edited

Loading

codecov bot commented Aug 22, 2024 •

edited

Loading

MajorLift Aug 30, 2024 •

edited

Loading