Skip to content

fix: [cherry-pick][V12.1.0] permit simulation design - fix style alignment (#26186)#26518

Merged
jpuri merged 1 commit intoVersion-v12.1.0from
cherry-pick-12.1.0-2845-permit-design-review
Aug 19, 2024
Merged

fix: [cherry-pick][V12.1.0] permit simulation design - fix style alignment (#26186)#26518
jpuri merged 1 commit intoVersion-v12.1.0from
cherry-pick-12.1.0-2845-permit-design-review

Conversation

@digiwand
Copy link
Copy Markdown
Contributor

@digiwand digiwand commented Aug 19, 2024

Description

Cherry-pick fix style alignment (#26186) into v12.1.0

various snapshot discrepancies that cause significant line diffs

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2845

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Aug 19, 2024
@digiwand digiwand changed the title fix: permit simulation design (#26186) fix: [cherry-pick][V12.1.0] permit simulation design - fix style alignment (#26186) Aug 19, 2024
@digiwand digiwand marked this pull request as ready for review August 19, 2024 17:39
@digiwand digiwand requested review from a team as code owners August 19, 2024 17:39
@jpuri jpuri merged commit 5d3abbc into Version-v12.1.0 Aug 19, 2024
@jpuri jpuri deleted the cherry-pick-12.1.0-2845-permit-design-review branch August 19, 2024 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants