fix: permit simulation design by OGPoyraz · Pull Request #26186 · MetaMask/metamask-extension

OGPoyraz · 2024-07-29T13:33:55Z

Description

This PR does a small alignment and pill padding update on permit simulations.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2845

Follow-up Cherry-picked PR: #26518

Manual testing steps

Go to test-dapp, trigger permit signature to verify change

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jpuri · 2024-07-29T13:57:20Z

ui/components/app/confirm/info/row/row.tsx

We need to ensure that it looks correct for all other cases.

Just to note, I will keep this convo in slack.

metamaskbot · 2024-07-29T14:05:52Z

Builds ready [9ce5b31]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (171 ± 211 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	384	112	65	31
		domContentLoaded	10	97	29	20	10
		load	49	2084	171	439	211
		domInteractive	10	97	29	20	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 48 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-07-30T10:00:37Z

Builds ready [5d21a80]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (397 ± 362 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	401	118	69	33
		domContentLoaded	10	97	29	23	11
		load	44	2488	397	754	362
		domInteractive	10	97	29	23	11

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 48 Bytes (0.00%)
common: 0 Bytes (0.00%)

github-actions · 2024-08-19T13:36:11Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-08-19T14:08:05Z

Builds ready [e96dbfe]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (85 ± 17 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	204	113	34	16
		domContentLoaded	40	169	80	36	17
		load	46	180	85	36	17
		domInteractive	10	79	32	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 48 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarqubecloud · 2024-08-19T14:19:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-19T14:48:53Z

Builds ready [322919d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (75 ± 12 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	174	103	31	15
		domContentLoaded	40	143	73	26	13
		load	47	143	75	25	12
		domInteractive	10	78	29	17	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 48 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-08-19T14:49:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.98%. Comparing base (e3aef95) to head (322919d).
Report is 28 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26186   +/-   ##
========================================
  Coverage    69.98%   69.98%           
========================================
  Files         1405     1405           
  Lines        48991    48992    +1     
  Branches     13697    13697           
========================================
+ Hits         34282    34283    +1     
  Misses       14709    14709

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

digiwand

Updated snapshots and verified the UI on chrome 👍🏼

digiwand · 2024-08-20T01:48:20Z

Follow-up cherry-pick PR into 12.1.0: #26518

Follow-up related fix to include decimals in calculation and tooltip when ellipsis is shown on fiat: #26523

OGPoyraz requested review from a team as code owners July 29, 2024 13:33

metamaskbot added the team-confirmations Push issues to confirmations team label Jul 29, 2024

matthewwalsh0 previously approved these changes Jul 29, 2024

View reviewed changes

digiwand previously approved these changes Jul 29, 2024

View reviewed changes

jpuri reviewed Jul 29, 2024

View reviewed changes

OGPoyraz dismissed stale reviews from digiwand and matthewwalsh0 via 79758ea July 29, 2024 14:09

OGPoyraz added 4 commits July 30, 2024 15:27

Fix permit simulation design

fd70334

Update snapshots

58e5a20

Snapshot update

5d6b03d

Another snapshot update

ed9b488

OGPoyraz force-pushed the 2845-permit-design-review branch from 4cd7e16 to ed9b488 Compare July 30, 2024 13:29

digiwand previously approved these changes Aug 2, 2024

View reviewed changes

Merge branch 'develop' into 2845-permit-design-review

e96dbfe

digiwand dismissed their stale review via e96dbfe August 19, 2024 13:35

fix: ConfirmPage snapshot

322919d

digiwand requested review from jpuri and matthewwalsh0 August 19, 2024 15:06

jpuri approved these changes Aug 19, 2024

View reviewed changes

digiwand approved these changes Aug 19, 2024

View reviewed changes

jpuri merged commit e48324c into develop Aug 19, 2024

jpuri deleted the 2845-permit-design-review branch August 19, 2024 15:07

github-actions bot locked and limited conversation to collaborators Aug 19, 2024

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 19, 2024

digiwand added release-12.1.0 Issue or pull request that will be included in release 12.1.0 rc-cherry-picked and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Aug 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: permit simulation design#26186

fix: permit simulation design#26186
jpuri merged 6 commits intodevelopfrom
2845-permit-design-review

OGPoyraz commented Jul 29, 2024 •

edited by digiwand

Loading

Uh oh!

jpuri Jul 29, 2024

Uh oh!

OGPoyraz Jul 29, 2024

Uh oh!

metamaskbot commented Jul 29, 2024

Uh oh!

metamaskbot commented Jul 30, 2024

Uh oh!

github-actions bot commented Aug 19, 2024

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

sonarqubecloud bot commented Aug 19, 2024

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

codecov bot commented Aug 19, 2024

Uh oh!

digiwand left a comment

Uh oh!

digiwand commented Aug 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

OGPoyraz commented Jul 29, 2024 • edited by digiwand Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

jpuri Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

OGPoyraz Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jul 29, 2024

Uh oh!

metamaskbot commented Jul 30, 2024

Uh oh!

github-actions bot commented Aug 19, 2024

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

sonarqubecloud bot commented Aug 19, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

codecov bot commented Aug 19, 2024

Codecov Report

Uh oh!

digiwand left a comment

Choose a reason for hiding this comment

Uh oh!

digiwand commented Aug 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

OGPoyraz commented Jul 29, 2024 •

edited by digiwand

Loading