Skip to content

feat: Update @blockaid/ppom_release to release 1.5.2#26494

Merged
jpuri merged 2 commits intodevelopfrom
ppom_version_update
Aug 19, 2024
Merged

feat: Update @blockaid/ppom_release to release 1.5.2#26494
jpuri merged 2 commits intodevelopfrom
ppom_version_update

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Aug 19, 2024

Description

Update @blockaid/ppom_release to release 1.5.2

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2989

Manual testing steps

  1. Go to test dapp
  2. Submit confirmations
  3. Ensure validation works as expected

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Aug 19, 2024
@jpuri jpuri requested review from a team as code owners August 19, 2024 12:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@socket-security
Copy link
Copy Markdown

socket-security bot commented Aug 19, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/ppom_release@1.5.2 network 0 3.36 MB blockaiduser

🚮 Removed packages: npm/@blockaid/ppom_release@1.5.1

View full report↗︎

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 19, 2024

Builds ready [17d1842]
Page Load Metrics (83 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint771721102411
domContentLoaded4712079199
load5113283199
domInteractive126431157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.98%. Comparing base (e3aef95) to head (17d1842).
Report is 25 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26494   +/-   ##
========================================
  Coverage    69.98%   69.98%           
========================================
  Files         1405     1405           
  Lines        48991    48991           
  Branches     13697    13697           
========================================
  Hits         34282    34282           
  Misses       14709    14709

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit 59e1135 into develop Aug 19, 2024
@jpuri jpuri deleted the ppom_version_update branch August 19, 2024 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 19, 2024
@digiwand digiwand added release-12.1.0 Issue or pull request that will be included in release 12.1.0 rc-cherry-picked and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Aug 20, 2024
@digiwand
Copy link
Copy Markdown
Contributor

digiwand commented Aug 20, 2024

Cherry-pick PR: #26499

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

rc-cherry-picked release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpuri @metamaskbot @digiwand @matthewwalsh0 @vinistevam