Skip to content

cherry-pick: Update @blockaid/ppom_release to release 1.5.2#26499

Merged
digiwand merged 1 commit intoVersion-v12.1.0from
ppom_update_cherry_pick
Aug 19, 2024
Merged

cherry-pick: Update @blockaid/ppom_release to release 1.5.2#26499
digiwand merged 1 commit intoVersion-v12.1.0from
ppom_update_cherry_pick

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Aug 19, 2024

Description

Update @blockaid/ppom_release to release 1.5.2

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2989

Manual testing steps

  1. Go to test dapp
  2. Submit confirmations
  3. Ensure validation works as expected

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Aug 19, 2024
@jpuri jpuri requested review from a team as code owners August 19, 2024 14:21
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/ppom_release@1.5.2 network 0 3.36 MB blockaiduser

🚮 Removed packages: npm/@blockaid/ppom_release@1.5.1

View full report↗︎

@digiwand
Copy link
Copy Markdown
Contributor

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (21e019a) to head (069923e).
Report is 1 commits behind head on Version-v12.1.0.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.1.0   #26499      +/-   ##
===================================================
- Coverage            69.62%   69.62%   -0.00%     
===================================================
  Files                 1363     1363              
  Lines                48417    48417              
  Branches             13349    13349              
===================================================
- Hits                 33708    33707       -1     
- Misses               14709    14710       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [069923e]
Page Load Metrics (159 ± 176 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint702941114723
domContentLoaded109531199
load491759159368176
domInteractive109530199

@digiwand digiwand merged commit 0072384 into Version-v12.1.0 Aug 19, 2024
@digiwand digiwand deleted the ppom_update_cherry_pick branch August 19, 2024 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants