fix: refactor: [cherry-pick][V12.1.0] Permit decimal fix + introduce ConfirmInfoRowTextTokenUnits component#26478
Merged
pedronfigueiredo merged 2 commits intoVersion-v12.1.0from Aug 19, 2024
Conversation
) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** No UI/UX changes Create reusable ConfirmInfoRowTextTokenUnits notes: - there is an outstanding bug ticket to redesign the display length of the amount to max 15 characters. This will be handled separately - there's also a precision issue being handle separately [](https://codespaces.new/MetaMask/metamask-extension/pull/26105?quickstart=1) ## **Related issues** Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2888 ## **Manual testing steps** 1. Create a redesign Permit transaction 2. Observe amount displays as expected ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
digiwand
commented
Aug 16, 2024
| // FIXME - Precision may be lost for large values when using formatAmount | ||
| /** @see {@link https://github.com/MetaMask/metamask-extension/issues/25755} */ | ||
| const tokenValue = formatAmount('en-US', resultBn); | ||
| const tokenValueMaxPrecision = formatAmountMaxPrecision('en-US', valueBN); |
Contributor
Author
There was a problem hiding this comment.
This was actually a bug. We should be reading resultBn here not valueBN
Contributor
Author
There was a problem hiding this comment.
fixed using the new component introduced here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.1.0 #26478 +/- ##
===================================================
- Coverage 69.62% 69.62% -0.00%
===================================================
Files 1362 1363 +1
Lines 48412 48410 -2
Branches 13347 13347
===================================================
- Hits 33703 33701 -2
Misses 14709 14709 ☔ View full report in Codecov by Sentry. |
…ign-conf-token-amount
Collaborator
Builds ready [f4f4079]
Page Load Metrics (227 ± 244 ms)
|
jpuri
reviewed
Aug 19, 2024
| const tokenValue = calcTokenAmount(value, decimals); | ||
|
|
||
| // FIXME - Precision may be lost for large values when using formatAmount | ||
| /** @see {@link https://github.com/MetaMask/metamask-extension/issues/25755} */ |
Contributor
There was a problem hiding this comment.
This issue has been fixed, we can get rid of this comment now.
Contributor
Author
There was a problem hiding this comment.
Turns out we haven't cherry-picked the Precision fix to 12.1.0 yet. Cherry-pick PR #26496
jpuri
approved these changes
Aug 19, 2024
Contributor
jpuri
left a comment
There was a problem hiding this comment.
Changes look good, I left a small feedback to remove an outdated comment.
vinistevam
approved these changes
Aug 19, 2024
matthewwalsh0
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks refactor: Create reusable ConfirmInfoRowTextTokenUnits component (#26105)
into V12.1.0
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2888
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2991 (cherry-pick issue)
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist