Skip to content

fix: [cherry-pick][V12.1.0] fix loss of precision for very big values #26496

Merged
jpuri merged 1 commit intoVersion-v12.1.0from
cherry-pick-12.1.0-numberformat_fix
Aug 19, 2024
Merged

fix: [cherry-pick][V12.1.0] fix loss of precision for very big values #26496
jpuri merged 1 commit intoVersion-v12.1.0from
cherry-pick-12.1.0-numberformat_fix

Conversation

@digiwand
Copy link
Copy Markdown
Contributor

@digiwand digiwand commented Aug 19, 2024 •
edited
Loading

Cherry-pick fix: change in number format to fix loss of precision for very big values (#25968) into Version-v12.1.0

no merge conflicts

cc: @jpuri

Description

Open in GitHub Codespaces

Related issues

Fixes: #25755

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner August 19, 2024 13:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand mentioned this pull request Aug 19, 2024
Merged
7 tasks
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Aug 19, 2024
@digiwand digiwand requested a review from jpuri August 19, 2024 13:20
@digiwand digiwand added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Aug 19, 2024
@digiwand digiwand mentioned this pull request Aug 19, 2024
Merged
7 tasks
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 19, 2024

Builds ready [ddc6bb4]
Page Load Metrics (167 ± 211 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69156952311
domContentLoaded95325115
load402084167440211
domInteractive95325115

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (db10925) to head (ddc6bb4).

Additional details and impacted files 
@@               Coverage Diff                @@
##           Version-v12.1.0   #26496   +/-   ##
================================================
  Coverage            69.62%   69.62%           
================================================
  Files                 1363     1363           
  Lines                48410    48417    +7     
  Branches             13347    13349    +2     
================================================
+ Hits                 33701    33708    +7     
  Misses               14709    14709

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit 21e019a into Version-v12.1.0 Aug 19, 2024
@jpuri jpuri deleted the cherry-pick-12.1.0-numberformat_fix branch August 19, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

Assignees

No one assigned

Labels

release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@digiwand @metamaskbot @jpuri