fix: fallback conversion rate for token market data #4615#26460
fix: fallback conversion rate for token market data #4615#26460bergeron merged 1 commit intoVersion-v12.1.0from
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/assets-controllers@33.0.0, npm/@metamask/polling-controller@8.0.0, npm/@metamask/preferences-controller@13.0.0, npm/async-mutex@0.5.0, npm/cockatiel@3.1.2, npm/jsonschema@1.2.4 |
| @@ -0,0 +1,58 @@ | |||
| diff --git a/dist/chunk-FGAZXVKS.js b/dist/chunk-FGAZXVKS.js | |||
There was a problem hiding this comment.
I don't have a PR to develop for this, since I plan to fix that with an actual package release. But patching for v12.1.0 and probably subsequent minor releases.
| linkType: hard | ||
|
|
||
| "@metamask/assets-controllers@npm:^33.0.0": | ||
| "@metamask/assets-controllers@npm:33.0.0": |
There was a problem hiding this comment.
Do I need to bump this on mobile as well? MetaMask/metamask-mobile#10562
There was a problem hiding this comment.
We will bump this on mobile too. Mobile won't consume this data until the PR you linked, so no hotfix just a regular fix.
Description
Patches MetaMask/core#4615
When the price API does not support the native currency (e.g. MATIC), prices are fetched in ETH and an additional conversion hop is performed to the native currency. But this hop was only being performed on the current price, and was missing on the extended market data like marketCap, allTimeHigh, etc.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist