Skip to content

feat: New token detail view#10562

Merged
gambinish merged 46 commits intomainfrom
feat/mmassets-161_new-token-detail-view
Aug 24, 2024
Merged

feat: New token detail view#10562
gambinish merged 46 commits intomainfrom
feat/mmassets-161_new-token-detail-view

Conversation

@gambinish
Copy link
Copy Markdown
Member

@gambinish gambinish commented Aug 12, 2024 •
edited
Loading

Description

Adds new Token Detail view. Should visually match extension.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-161

Manual testing steps

  1. Add different tokens to Wallet
  2. Click into detail screen to validate the token details and market details
  3. Values should match with extension on same view
  4. Visually should match Figma mockups: https://www.figma.com/design/TfVzSMJA8KwpWX8TTWQ2iO/Asset-list-and-details?node-id=1167-101656

Screenshots/Recordings

Screen.Recording.2024-08-13.at.9.51.18.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

bergeron
bergeron reviewed Aug 12, 2024
View reviewed changes
bergeron
bergeron reviewed Aug 12, 2024
View reviewed changes
bergeron
bergeron reviewed Aug 12, 2024
View reviewed changes
@gambinish gambinish marked this pull request as ready for review August 14, 2024 04:16
@gambinish gambinish requested a review from a team as a code owner August 14, 2024 04:16
@gambinish gambinish added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E labels Aug 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dd642e1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3ea872da-1dcd-4e6d-b714-a4d63dc53b58

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish requested a review from salimtb August 14, 2024 05:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9f79e69
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f406b57b-27ce-44af-b5c0-db729af6d8e7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cb966fe
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/329d34ce-a803-40f3-b276-aaeddcd9a9df

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 528d2c3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3c307c75-b246-46a5-a28d-b2e986fe1a5c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L previously approved these changes Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from platform. Just had one question about eslint.

Cal-L
Cal-L approved these changes Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.5% Coverage on New Code
6.8% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ea2688e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dd7c2970-e9bb-498e-a9ca-b3fb4d3398dc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish merged commit d95e1fc into main Aug 24, 2024
@gambinish gambinish deleted the feat/mmassets-161_new-token-detail-view branch August 24, 2024 00:03
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

@sahar-fehri sahar-fehri Awaiting requested review from sahar-fehri

@salimtb salimtb Awaiting requested review from salimtb

@bergeron bergeron Awaiting requested review from bergeron

Assignees

No one assigned

Labels

release-7.31.0 Issue or pull request that will be included in release 7.31.0 team-assets

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gambinish @salimtb @codecov-commenter @bergeron @Cal-L @metamaskbot @SamuelSalas