Skip to content

Version v12.1.0 cherrypick 43b8031#26158

Merged
gantunesr merged 2 commits intoVersion-v12.1.0from
Version-v12.1.0-cherrypick-43b8031
Aug 19, 2024
Merged

Version v12.1.0 cherrypick 43b8031#26158
gantunesr merged 2 commits intoVersion-v12.1.0from
Version-v12.1.0-cherrypick-43b8031

Conversation

@montelaidev
Copy link
Copy Markdown
Contributor

@montelaidev montelaidev commented Jul 26, 2024

Description

Cherry pick fix for networks with the same chain id.
PR 25805

And cherry picking the fix for the showing of fiat balances for test net accounts.
#26224

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev requested review from a team as code owners July 26, 2024 12:34
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev changed the base branch from develop to Version-v12.1.0 July 26, 2024 12:34
Copy link
Copy Markdown
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, here are some screenshots:

Screenshot 2024-07-26 at 15 57 09
Screenshot 2024-07-26 at 15 57 21
Screenshot 2024-07-26 at 15 57 27
Screenshot 2024-07-26 at 15 58 27

@gantunesr gantunesr merged commit 71db1eb into Version-v12.1.0 Aug 19, 2024
@gantunesr gantunesr deleted the Version-v12.1.0-cherrypick-43b8031 branch August 19, 2024 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants