fix: selected network when there are two with the same chain id. #25805
Merged
montelaidev merged 17 commits intodevelopfrom Jul 19, 2024
Merged
fix: selected network when there are two with the same chain id. #25805montelaidev merged 17 commits intodevelopfrom
montelaidev merged 17 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25805 +/- ##
===========================================
+ Coverage 69.69% 69.69% +0.01%
===========================================
Files 1401 1401
Lines 49577 49590 +13
Branches 13701 13707 +6
===========================================
+ Hits 34548 34561 +13
Misses 15029 15029 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [c9bc7c6]
Page Load Metrics (219 ± 215 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ccharly
reviewed
Jul 16, 2024
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Contributor
|
Hey @montelaidev, did you specifically ask for @MetaMask/design-system-engineers review for this PR? Trying to figure out why we got tagged as code owners here. Happy for our team to review if so |
Contributor
Author
Hey @georgewrmarshall, there was a change in a design system component that was reverted. I think its ok now, we can remove @MetaMask/design-system-engineers from the reviewers. Thanks for checking in! |
Collaborator
Builds ready [b741527]
Page Load Metrics (325 ± 281 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ccharly
reviewed
Jul 19, 2024
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Collaborator
Builds ready [cd9e0b7]
Page Load Metrics (157 ± 168 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ccharly
reviewed
Jul 19, 2024
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
ccharly
approved these changes
Jul 19, 2024
matthewwalsh0
approved these changes
Jul 19, 2024
Contributor
|
Do we know how/when this regressed? Please test re: v12, 12.1, etc, because this is problematic |
Contributor
Author
Collaborator
Builds ready [1e3ee98]
Page Load Metrics (140 ± 155 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Collaborator
Builds ready [46b22c1]
Page Load Metrics (458 ± 384 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue when there are two networks with the same chain id and the default network is selected.
Related issues
Fixes: #25763
Manual testing steps
1Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist