Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25624 +/- ##
========================================
Coverage 69.60% 69.60%
========================================
Files 1364 1364
Lines 48172 48172
Branches 13291 13291
========================================
Hits 33526 33526
Misses 14646 14646 ☔ View full report in Codecov by Sentry. |
digiwand
approved these changes
Jul 2, 2024
dan437
approved these changes
Jul 2, 2024
Collaborator
Builds ready [4c95bcb]
Page Load Metrics (155 ± 165 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The e2e that are using page objects are failing due to this error:
Waiting for element to be located By(xpath, .//*[contains(concat(' ', normalize-space(./@class), ' '), ' unlock-page__title ')][(contains(string(.), 'Welcome back!') or contains(string(.), 'Welcomeback!'))]).It looks like the selector is not correct. This PR uses the data test id to find the correct element.
Explanation: this PR removed the css selector, and this other PR implemented page objects with the old selector -possibly the last PR was not updated, so the tests were green, but once the 2 have been merged, now this selector is not found and fails in the subsequent branches
ci failure here
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist