Skip to content

refactor: Replace deprecated mixins with Text component in unlock-page.component.js#25227

Merged
garrettbear merged 13 commits intoMetaMask:developfrom
Devin-Applications:devin/mixin-unlock
Jul 1, 2024
Merged

refactor: Replace deprecated mixins with Text component in unlock-page.component.js#25227
garrettbear merged 13 commits intoMetaMask:developfrom
Devin-Applications:devin/mixin-unlock

Conversation

@Devin-Apps
Copy link
Copy Markdown
Contributor

@Devin-Apps Devin-Apps commented Jun 11, 2024 •
edited by github-actions bot
Loading

Description

This pull request replaces the deprecated mixins in the unlock-page.component.js and index.scss files with the Text component. The changes include updating the unlock-page__title class to use the Text component with appropriate properties and removing the deprecated mixin instance from the SCSS file.

Devin Run Link: https://preview.devin.ai/devin/de079f9a40fd45adb09783a36409256c

Open in GitHub Codespaces

Related issues

Partially Fixes: #20496

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Verify that the "UnlockPage" component renders correctly with the updated Text component
  3. Ensure that the unlock-page__title class is replaced with [data-testid="unlock-page-title"] in the test/e2e/tests/settings/auto-lock.spec.js file

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 11, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall
georgewrmarshall reviewed Jun 11, 2024
View reviewed changes
georgewrmarshall
georgewrmarshall reviewed Jun 11, 2024
View reviewed changes
georgewrmarshall
georgewrmarshall reviewed Jun 11, 2024
View reviewed changes
@georgewrmarshall georgewrmarshall requested a review from a team June 12, 2024 22:33
georgewrmarshall
georgewrmarshall reviewed Jun 12, 2024
View reviewed changes
georgewrmarshall
georgewrmarshall reviewed Jun 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment

@georgewrmarshall georgewrmarshall requested a review from a team June 12, 2024 22:50
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (d403213) to head (56ab096).
Report is 9 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25227   +/-   ##
========================================
  Coverage    69.69%   69.69%           
========================================
  Files         1350     1350           
  Lines        47865    47865           
  Branches     13199    13199           
========================================
  Hits         33355    33355           
  Misses       14510    14510

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 13, 2024
georgewrmarshall
georgewrmarshall reviewed Jun 13, 2024
View reviewed changes
georgewrmarshall
georgewrmarshall reviewed Jun 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment! Then I can approve

@Devin-Apps @georgewrmarshall
Added the polymorphic as prop
932a657 
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
@Devin-Apps
Copy link
Copy Markdown
Contributor Author

Devin-Apps commented Jun 13, 2024

Resolved the comment

georgewrmarshall
georgewrmarshall reviewed Jun 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update snapshot otherwise LGTM

georgewrmarshall
georgewrmarshall approved these changes Jun 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@georgewrmarshall georgewrmarshall marked this pull request as ready for review June 28, 2024 17:15
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner June 28, 2024 17:15
@georgewrmarshall georgewrmarshall requested a review from a team June 28, 2024 17:15
@garrettbear garrettbear merged commit d9ce2dd into MetaMask:develop Jul 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 19, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 19, 2024

No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

+1 more reviewer

@garrettbear garrettbear garrettbear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external-contributor release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace deprecated mixins @include H1 - @include H9 in SCSS with Text component

4 participants

@Devin-Apps @metamaskbot @georgewrmarshall @garrettbear