test: add e2e to swap with snap account by plasmacorral · Pull Request #25558 · MetaMask/metamask-extension

plasmacorral · 2024-06-27T12:47:25Z

Description

Related issues

Fixes: 469

Manual testing steps

yarn build:test:mv2 then ENABLE_MV3=false yarn test:e2e:single test/e2e/accounts/snap-account-eth-swap.spec.ts --browser=firefox
yarn build:test then yarn test:e2e:single test/e2e/accounts/snap-account-eth-swap.spec.ts --browser=chrome

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-27T12:47:37Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-06-28T15:42:08Z

Builds ready [70bf3c0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (82 ± 12 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	210	113	29	14
		domContentLoaded	10	94	36	22	11
		load	46	141	82	24	12
		domInteractive	10	94	36	22	11

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-06-28T15:42:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (198bedd) to head (c43a05e).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25558   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48172    48172           
  Branches     13291    13291           
========================================
  Hits         33526    33526           
  Misses       14646    14646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/e2e/accounts/snap-account-eth-swap.spec.ts

seaona · 2024-07-01T11:32:47Z

Overall looks good 🔥 Just added a small suggestion.
Note: there's an unrelated failure in current ci, which will be fixed by this PR. Once it's merged to develop, feel free to update your branch and that should fix your jobs

metamaskbot · 2024-07-01T19:14:08Z

Builds ready [b5c4601]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (361 ± 431 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	511	117	92	44
		domContentLoaded	10	199	32	39	19
		load	43	3147	361	898	431
		domInteractive	10	199	32	39	19

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

gantunesr

The code looks good, in general is a good practice to not have in-values inside the code since it helps to prevent bugs because of typos. For example,

const DAI = 'DAI';
const TEST_ETH = 'TESTETH';

...

await checkActivityTransaction(driver, {
  index: 0,
  amount: '0.001',
  swapFrom: TEST_ETH,
  swapTo: DAI,
});

test/e2e/accounts/snap-account-eth-swap.spec.ts

sonarqubecloud · 2024-07-02T00:54:01Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

plasmacorral · 2024-07-02T01:14:52Z

The code looks good, in general is a good practice to not have in-values inside the code since it helps to prevent bugs because of typos. For example,
const DAI = 'DAI';
const TEST_ETH = 'TESTETH';

...

await checkActivityTransaction(driver, {
  index: 0,
  amount: '0.001',
  swapFrom: TEST_ETH,
  swapTo: DAI,
});

Updated. Thank you!

metamaskbot · 2024-07-02T01:24:46Z

Builds ready [c43a05e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (149 ± 173 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	131	100	17	8
		domContentLoaded	9	56	26	13	6
		load	40	1716	149	360	173
		domInteractive	9	56	26	13	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

chloeYue

LGTM !

add e2e to swap with snap account

bf8f4aa

plasmacorral requested a review from a team as a code owner June 27, 2024 12:47

plasmacorral marked this pull request as draft June 27, 2024 12:48

metamaskbot added the team-accounts-framework Accounts team label Jun 27, 2024

plasmacorral added the e2e-test End to end test for the MetaMask extension label Jun 27, 2024

plasmacorral self-assigned this Jun 27, 2024

plasmacorral added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 27, 2024

plasmacorral changed the title ~~add e2e to swap with snap account~~ e2e test to swap with snap account Jun 27, 2024

fix: linting

0f2f79d

plasmacorral changed the title ~~e2e test to swap with snap account~~ test: add e2e to swap with snap account Jun 27, 2024

Merge branch 'develop' into e2e-snap-account-swap

aeaa111

plasmacorral marked this pull request as ready for review June 27, 2024 17:49

plasmacorral added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 27, 2024

Merge branch 'develop' into e2e-snap-account-swap

70bf3c0

plasmacorral added 2 commits June 28, 2024 12:49

Merge branch 'develop' into e2e-snap-account-swap

fff2040

Merge branch 'develop' into e2e-snap-account-swap

a3d5681

seaona reviewed Jul 1, 2024

View reviewed changes

test/e2e/accounts/snap-account-eth-swap.spec.ts Outdated Show resolved Hide resolved

plasmacorral added 3 commits July 1, 2024 12:24

Merge branch 'develop' into e2e-snap-account-swap

2047c6e

Simply test fixtures per suggestion

5633745

Merge branch 'develop' into e2e-snap-account-swap

0ff5d73

plasmacorral removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 1, 2024

Fix: linting

b5c4601

plasmacorral added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 1, 2024

plasmacorral requested a review from seaona July 1, 2024 19:03

seaona previously approved these changes Jul 1, 2024

View reviewed changes

gantunesr reviewed Jul 2, 2024

View reviewed changes

test/e2e/accounts/snap-account-eth-swap.spec.ts Outdated Show resolved Hide resolved

test/e2e/accounts/snap-account-eth-swap.spec.ts Outdated Show resolved Hide resolved

use import instead of require, and update names

49afa37

plasmacorral dismissed seaona’s stale review via 49afa37 July 2, 2024 00:52

Merge branch 'develop' into e2e-snap-account-swap

c43a05e

plasmacorral requested review from gantunesr and seaona July 2, 2024 01:25

seaona approved these changes Jul 2, 2024

View reviewed changes

chloeYue approved these changes Jul 2, 2024

View reviewed changes

plasmacorral merged commit c641981 into develop Jul 2, 2024

plasmacorral deleted the e2e-snap-account-swap branch July 2, 2024 12:30

github-actions bot locked and limited conversation to collaborators Jul 2, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 2, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add e2e to swap with snap account#25558

test: add e2e to swap with snap account#25558
plasmacorral merged 12 commits intodevelopfrom
e2e-snap-account-swap

plasmacorral commented Jun 27, 2024 •

edited by hjetpoluru

Loading

Uh oh!

github-actions bot commented Jun 27, 2024

Uh oh!

metamaskbot commented Jun 28, 2024

Uh oh!

codecov bot commented Jun 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

seaona commented Jul 1, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Jul 1, 2024

Uh oh!

gantunesr left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 2, 2024

Uh oh!

plasmacorral commented Jul 2, 2024

Uh oh!

metamaskbot commented Jul 2, 2024

Uh oh!

chloeYue left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

plasmacorral commented Jun 27, 2024 • edited by hjetpoluru Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 27, 2024

Uh oh!

metamaskbot commented Jun 28, 2024

Uh oh!

codecov bot commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

seaona commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Jul 1, 2024

Uh oh!

gantunesr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 2, 2024

Quality Gate passed

Uh oh!

plasmacorral commented Jul 2, 2024

Uh oh!

metamaskbot commented Jul 2, 2024

Uh oh!

chloeYue left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

plasmacorral commented Jun 27, 2024 •

edited by hjetpoluru

Loading

codecov bot commented Jun 28, 2024 •

edited

Loading

seaona commented Jul 1, 2024 •

edited

Loading

gantunesr left a comment •

edited

Loading