Skip to content

fix: failingt e2e Click bridge button from asset page @no-mmi loads portfolio tab when flag is turned off#25607

Merged
seaona merged 1 commit intodevelopfrom
fix-bridge-e2e
Jul 1, 2024
Merged

fix: failingt e2e Click bridge button from asset page @no-mmi loads portfolio tab when flag is turned off#25607
seaona merged 1 commit intodevelopfrom
fix-bridge-e2e

Conversation

@seaona
Copy link
Copy Markdown
Member

@seaona seaona commented Jul 1, 2024 •
edited
Loading

Description

The test is failing since we are trying to manually add a token which is already added using fixtures.
See ci failure here.

Open in GitHub Codespaces

Related issues

Fixes: #25608

Manual testing steps

  1. Check ci

Screenshots/Recordings

image

Failure and fix:

bridge-e2e-failure-and-fix.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona added team-extension-platform Extension Platform team flaky tests labels Jul 1, 2024
@seaona seaona self-assigned this Jul 1, 2024
@seaona seaona requested a review from a team as a code owner July 1, 2024 10:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 1, 2024
@seaona seaona removed the team-confirmations Push issues to confirmations team label Jul 1, 2024
@DDDDDanica
Copy link
Copy Markdown
Contributor

DDDDDanica commented Jul 1, 2024

LGTM ! Thanks for quick fix !

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 1, 2024

Builds ready [7dc3b9d]
Page Load Metrics (162 ± 162 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint741971173015
domContentLoaded96532167
load411632162338162
domInteractive96532167
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (3ea381d) to head (7dc3b9d).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25607   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1365     1365           
  Lines        48198    48198           
  Branches     13297    13297           
========================================
  Hits         33545    33545           
  Misses       14653    14653

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seaona seaona mentioned this pull request Jul 1, 2024
Merged
7 tasks
chloeYue
chloeYue approved these changes Jul 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seaona seaona merged commit df81e73 into develop Jul 1, 2024
@seaona seaona deleted the fix-bridge-e2e branch July 1, 2024 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 1, 2024
@seaona seaona added the area-qa Relating to QA work (Quality Assurance) label Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@chloeYue chloeYue chloeYue approved these changes

Assignees

@seaona seaona

Labels

area-qa Relating to QA work (Quality Assurance) flaky tests release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky test: Click bridge button from asset page @no-mmi loads portfolio tab when flag is turned off

4 participants

@seaona @DDDDDanica @metamaskbot @chloeYue