Skip to content

test: UX: Multichain: Add test for mutiple dapp confirmation order#25536

Merged
darkwing merged 2 commits intodevelopfrom
multichain-three-dapp-test
Jun 28, 2024
Merged

test: UX: Multichain: Add test for mutiple dapp confirmation order#25536
darkwing merged 2 commits intodevelopfrom
multichain-three-dapp-test

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented Jun 26, 2024 •
edited
Loading

Description

This PR ensures no dapp-specified transactions get dropped when triggering transactions on dapps, switching to a dapp on another chain, and triggering another transaction.

Open in GitHub Codespaces

Related issues

Supercedes: #25459
Fixes:

Manual testing steps

  1. Open Tab 1, connect to Uniswap on Ethereum Mainnet
  2. Open Tab 2, connect to PancakeSwap on BNB Chain
  3. Open Tab 3, connect to Test Dapp on Sepolia
  4. Initiate a swap on Tab 1 and Tab 2 BUT DO NOT CONFIRM IT, JUST MOVE ON TO THE NEXT TAB
  5. Initiate a send on Tab 3 BUT DO NOT CONFIRM IT
  6. On the confirmation screen, you should still see the first confirmation from Tab 1 (Uniswap) on Ethereum Mainnet; confirm or reject it. See the confirmation window close
  7. A new confirmation popup should come up with the PancakeSwap/ Tab 2 confirmation on BNB chain; confirm or reject it. See the confirmation window close
  8. See one last confirmation screen pop up for the Tab 3 / Test Dapp send on Sepolia. Confirm or reject it.

Screenshots/Recordings

Before

After

Video of equivalent, manual test of this E2E
https://github.com/MetaMask/metamask-extension/assets/46655/cc4578f9-602c-4c2e-835d-79e4ca8ed762

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner June 26, 2024 21:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Jun 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 26, 2024

Builds ready [1e5b508]
Page Load Metrics (49 ± 5 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6210081105
domContentLoaded8271242
load377149105
domInteractive8271242
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.70%. Comparing base (2a61f59) to head (c438f40).
Report is 7 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25536   +/-   ##
========================================
  Coverage    69.70%   69.70%           
========================================
  Files         1349     1349           
  Lines        47864    47864           
  Branches     13205    13205           
========================================
  Hits         33360    33360           
  Misses       14504    14504

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkwing darkwing changed the title UX: Multichain: Add test for mutiple dapp confirmation order test: UX: Multichain: Add test for mutiple dapp confirmation order Jun 26, 2024
@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jun 27, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 27, 2024

Builds ready [c438f40]
Page Load Metrics (46 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint579675105
domContentLoaded8191131
load37734694
domInteractive8191131
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

chloeYue
chloeYue approved these changes Jun 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you add these scenarios on test coverage sheet and fill the version when e2e tests are added so we can track? Thanks !

@darkwing darkwing merged commit fdc898e into develop Jun 28, 2024
@darkwing darkwing deleted the multichain-three-dapp-test branch June 28, 2024 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@chloeYue chloeYue chloeYue approved these changes

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@darkwing @metamaskbot @sahar-fehri @chloeYue