fix: UX: Check for unconfirmed transactions on all networks#25459
Closed
fix: UX: Check for unconfirmed transactions on all networks#25459
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
f8636fa to
58ad823
Compare
58ad823 to
03c3bf1
Compare
Collaborator
Builds ready [a394768]
Page Load Metrics (148 ± 206 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25459 +/- ##
========================================
Coverage 69.65% 69.66%
========================================
Files 1347 1347
Lines 47808 47814 +6
Branches 13187 13188 +1
========================================
+ Hits 33300 33306 +6
Misses 14508 14508 ☔ View full report in Codecov by Sentry. |
7 tasks
Contributor
Author
|
Closing as the code change isn't necessary, and it was a result of a bad manual test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previously used
getUnapprovedTransactionsonly checked for unapproved transactions on the current chain, not all chains, so if the user has transactions/confirmations on more than 2 simultaneous networks, the middle ones get dropped/forgotten. This PR ensures no dapp-specified transactions get dropped when moving around tabs.Related issues
Fixes:
Manual testing steps
Tab 1, connect toUniswaponEthereum MainnetTab 2, connect toPancakeSwaponBNB ChainTab 3, connect toTest DapponSepoliaTab 1andTab 2BUT DO NOT CONFIRM IT, JUST MOVE ON TO THE NEXT TABTab 3BUT DO NOT CONFIRM ITTab 1(Uniswap) onEthereum Mainnet; confirm or reject it. See the confirmation window closePancakeSwap/Tab 2confirmation onBNBchain; confirm or reject it. See the confirmation window closeTab 3/Test Dappsend onSepolia. Confirm or reject it.Screenshots/Recordings
Before
After
Screen.Recording.2024-06-20.at.8.43.18.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist