Merged
Conversation
We were submitting Segment events in the MetaMetrics constructor without cathing errors. This was the sole place where we failed to catch errors resulting from Segment calls. Fixes #25244
7e9d962 to
ee0b90d
Compare
danjm
previously approved these changes
Jun 12, 2024
Collaborator
Builds ready [ee0b90d]
Page Load Metrics (436 ± 428 ms)
|
## **Description** Disables MV3 for the MV2 Flask production build. This was seemingly missed when setting up the CI to build for production and caused problems with the latest build submitted to Firefox. Also updates the release script to use MV2 builds for Firefox. [](https://codespaces.new/MetaMask/metamask-extension/pull/25209?quickstart=1)
Contributor
|
I manually tested this. I was able to repro on v11.16.9 by entering this in the background console: code snippetThis caused infinite loading on 11.16.9, but 11.16.10 resolves that problem and MetaMask can continued to be used normally. I also verified in this case that a sentry error is successfully captured. |
Collaborator
Builds ready [87d2795]
Page Load Metrics (241 ± 244 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See changelog for details