fix: Disable MV3 for MV2 Flask production build#25209
Merged
FrederikBolding merged 2 commits intodevelopfrom Jun 11, 2024
Merged
fix: Disable MV3 for MV2 Flask production build#25209FrederikBolding merged 2 commits intodevelopfrom
FrederikBolding merged 2 commits intodevelopfrom
Conversation
zone-live
approved these changes
Jun 11, 2024
danjm
approved these changes
Jun 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25209 +/- ##
========================================
Coverage 65.59% 65.59%
========================================
Files 1362 1362
Lines 54167 54167
Branches 14167 14167
========================================
Hits 35527 35527
Misses 18640 18640 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [2c82e65]
Page Load Metrics (133 ± 180 ms)
Bundle size diffs
|
Collaborator
|
Missing release label release-11.16.10 on PR. Adding release label release-11.16.10 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 11.16.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disables MV3 for the MV2 Flask production build. This was seemingly missed when setting up the CI to build for production and caused problems with the latest build submitted to Firefox.
Also updates the release script to use MV2 builds for Firefox.