Skip to content

fix: addressing feedbacks in typed sign alerts#25218

Merged
jpuri merged 1 commit intoVersion-v12.0.0from
addressing_feedbacks_alert_system
Jun 12, 2024
Merged

fix: addressing feedbacks in typed sign alerts#25218
jpuri merged 1 commit intoVersion-v12.0.0from
addressing_feedbacks_alert_system

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Jun 11, 2024

Description

Addressing feedbacks in alerts integrated to typed sign data pages.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2615

Manual testing steps

  1. Go to test DAPP
  2. Submit malicious typed sign request
  3. Look at the alerts displayed

Screenshots/Recordings

Screenshot 2024-06-10 at 1 31 00 PM Screenshot 2024-06-10 at 1 30 54 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jun 11, 2024
@jpuri jpuri requested review from a team as code owners June 11, 2024 13:37
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 11, 2024
@jpuri jpuri merged commit 00f7774 into Version-v12.0.0 Jun 12, 2024
@jpuri jpuri deleted the addressing_feedbacks_alert_system branch June 12, 2024 08:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants