fix: addressing feedbacks in typed sign alerts#25163
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…k-extension into typed_sign_alerts_fixes
matthewwalsh0
previously approved these changes
Jun 10, 2024
vinistevam
reviewed
Jun 11, 2024
| @@ -202,7 +202,7 @@ describe('ConfirmFooter', () => { | |||
| }; | |||
| it('renders the review alerts button when there are unconfirmed alerts', () => { | |||
Contributor
There was a problem hiding this comment.
isn't it the case to update the description to something like: renders the confirm button when there is one unconfirmed alert?
vinistevam
approved these changes
Jun 11, 2024
matthewwalsh0
approved these changes
Jun 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25163 +/- ##
========================================
Coverage 65.64% 65.64%
========================================
Files 1362 1362
Lines 54189 54189
Branches 14112 14112
========================================
Hits 35572 35572
Misses 18617 18617 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [ebe2a8f]
Page Load Metrics (161 ± 221 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addressing feedbacks in alerts integrated to typed sign data pages.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2615
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist