fix: hide privacy policy toast during onboarding, and for onboarded users by jonybur · Pull Request #25217 · MetaMask/metamask-extension

jonybur · 2024-06-11T13:17:42Z

Description

Fixes two bugs:

Privacy policy toast should not be seen during onboarding
Users who onboarded after the privacy policy date should not see the new privacy policy toast.

Related issues

Fixes:

Manual testing steps

New user onbaording after the date:

Set the privacy policy date to a date in the future from today
Onboard (create a new user)
User should not see the privacy policy toast at any moment

New user onboarding before the date:

Set the privacy policy date to a date in the past from today.
Onboard (create a new user)
User should not see the privacy policy toast at any moment
Set the privacy policy date to a date in the future from today
User should not see the privacy policy toast on the home screen

Old user after the privacy policy date:

Have a user already onboarded
Make sure the onboardingDate is null in the redux state (this simulates a user who has registered before this PR has been in production)
Set the privacy policy date to a date in the future from today
User should not see the new privacy policy toast

Old user before the privacy policy date:

Have a user onboarded
Make sure the onboardingDate is null in the redux state (this simulates a user who has registered before this PR has been in production)
Set the privacy policy date to a date in the past before today
User should see the new privacy policy toast

TL;DR: If the privacy policy date is in the future, the user should never see it -BUT- if the privacy policy is in the past, the user should see it, as long as the user onboarded before the privacy policy date.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-11T13:17:55Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…into jb-privacy-policy-hotfix

…sk-extension into jb-privacy-policy-hotfix

codecov · 2024-06-12T14:32:47Z

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 65.66%. Comparing base (32af889) to head (0268bea).
Report is 5 commits behind head on develop.

Files	Patch %	Lines
ui/selectors/selectors.js	50.00%	4 Missing ⚠️
app/scripts/controllers/app-state.js	0.00%	3 Missing ⚠️
ui/store/actions.ts	33.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25217      +/-   ##
===========================================
+ Coverage    65.65%   65.66%   +0.01%     
===========================================
  Files         1368     1368              
  Lines        54271    54301      +30     
  Branches     14192    14200       +8     
===========================================
+ Hits         35627    35652      +25     
- Misses       18644    18649       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-12T14:45:32Z

Builds ready [0268bea]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (552 ± 421 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	147	92	20	10
		domContentLoaded	8	26	12	5	2
		load	40	2345	552	877	421
		domInteractive	8	26	12	5	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 138 Bytes (0.00%)
ui: 62 Bytes (0.00%)
common: 220 Bytes (0.00%)

salimtb · 2024-06-12T16:15:06Z

Great work ! is it posible to add an e2e test for this ?

salimtb · 2024-06-12T16:17:18Z

ui/pages/onboarding-flow/onboarding-flow.js

  const isFromReminder = new URLSearchParams(search).get('isFromReminder');
  const trackEvent = useContext(MetaMetricsContext);

+  useEffect(() => {


can we add a comment on the top of this use effect to explain why we have it here ?

salimtb · 2024-06-12T16:19:08Z

ui/store/actions.ts

  };
 }

+export function setOnboardingDate() {


is it possible to add a unit test for this function on the action.test.js ? should be sample but better for the test coverage

jonybur · 2024-06-12T16:23:09Z

@salimtb If this needs to go in today as a hotfix, I don't think we have enough time to add the tests you are asking. We can add them on a later date if you wish. I'd like @darkwing to confirm the urgency of this PR.

bergeron · 2024-06-12T16:54:49Z

I haven't seen a toast appear yet when following the steps in New user onboarding before the date:

Edit: Maybe i just need to pick a better dummy date to satisfy currentDate >= newPrivacyPolicyDate. Going past June 18 wouldn't do so.

bergeron

Ok with some minor code edits i think ive reproduced all the cases correctly

metamaskbot · 2024-08-19T15:11:51Z

No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut.

darkwing and others added 6 commits June 10, 2024 13:22

Fix #25035 - Ensure toasts only display on the home screen

38e9693

Add jest tests

67c2bb9

Fix lint

b21e88a

Merge branch 'develop' into home-toasts

12729a9

Hide privacy policy toast during onboarding

ed49c79

Do not show privacy policy date for onboarded users

34a43e6

jonybur requested a review from a team as a code owner June 11, 2024 13:17

Update snap, test

bd9c746

jonybur added the team-core-extension-ux Core Extension UX team label Jun 11, 2024

Jonathan Bursztyn and others added 10 commits June 11, 2024 16:28

Fix action mock

31be9f2

Await dispatch

49f0c5f

Merge branch 'home-toasts' of github.com:MetaMask/metamask-extension …

0a93407

…into jb-privacy-policy-hotfix

Merge toasts changes

4164321

Update test

808a545

Fix test

a1de3fc

Change type of dispatch

c67ed95

Merge branch 'develop' into jb-privacy-policy-hotfix

f1a821a

Update snapshot

e824d28

Merge branch 'jb-privacy-policy-hotfix' of github.com:MetaMask/metama…

2149bed

…sk-extension into jb-privacy-policy-hotfix

darkwing mentioned this pull request Jun 11, 2024

fix: Fix #25035 - Ensure toasts only display on the home screen #25187

Closed

7 tasks

NidhiKJha and others added 6 commits June 12, 2024 11:23

updated snapshot

e010e4f

updated sentry

f6bc73a

Merge branch 'develop' into jb-privacy-policy-hotfix

7e8bfb5

sentry bool update

949159d

Merge branch 'develop' into jb-privacy-policy-hotfix

92b37a5

changed sentry config

0268bea

salimtb reviewed Jun 12, 2024

View reviewed changes

bergeron approved these changes Jun 12, 2024

View reviewed changes

bergeron self-requested a review June 12, 2024 16:53

bergeron approved these changes Jun 12, 2024

View reviewed changes

darkwing approved these changes Jun 12, 2024

View reviewed changes

salimtb approved these changes Jun 12, 2024

View reviewed changes

jonybur merged commit 7e24e8f into develop Jun 12, 2024

jonybur deleted the jb-privacy-policy-hotfix branch June 12, 2024 17:53

github-actions bot locked and limited conversation to collaborators Jun 12, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 12, 2024

hesterbruikman removed the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 12, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: hide privacy policy toast during onboarding, and for onboarded users#25217

fix: hide privacy policy toast during onboarding, and for onboarded users#25217
jonybur merged 23 commits intodevelopfrom
jb-privacy-policy-hotfix

jonybur commented Jun 11, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jun 11, 2024

Uh oh!

codecov bot commented Jun 12, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

salimtb commented Jun 12, 2024 •

edited

Loading

Uh oh!

salimtb Jun 12, 2024

Uh oh!

salimtb Jun 12, 2024

Uh oh!

jonybur commented Jun 12, 2024 •

edited

Loading

Uh oh!

bergeron commented Jun 12, 2024 •

edited

Loading

Uh oh!

bergeron left a comment

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

jonybur commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 11, 2024

Uh oh!

codecov bot commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

salimtb commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

salimtb Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

salimtb Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

jonybur commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bergeron commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bergeron left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jonybur commented Jun 11, 2024 •

edited

Loading

codecov bot commented Jun 12, 2024 •

edited

Loading

salimtb commented Jun 12, 2024 •

edited

Loading

jonybur commented Jun 12, 2024 •

edited

Loading

bergeron commented Jun 12, 2024 •

edited

Loading