fix (cherry-pick): Remove old What's New messages (#25048) for 12.0.0#25157
Merged
HowardBraham merged 2 commits intoVersion-v12.0.0from Jun 12, 2024
Merged
Conversation
## **Description** Removes legacy What's New messages, leaving only the Firefox WN *just* so that we can keep the shape of data here. This PR ensures _no_ What's New messages display at this time. [](https://codespaces.new/MetaMask/metamask-extension/pull/25048?quickstart=1) ## **Related issues** Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2613 ## **Manual testing steps** 1. Install fresh MetaMask in Chrome 2. See no "What's New" items. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ec3d93b to
183bb25
Compare
Contributor
There was a problem hiding this comment.
I don't have full context of this PR but looking good left a couple comments:
- Confirmed What's New Modal doesn't appear in fresh install of the extension ✅
- Checked no instances of removed local keys from
enremain ✅ - Checked no instances of removed consts remain ❌
Collaborator
Builds ready [183bb25]
Page Load Metrics (138 ± 169 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [1ab073f]
Page Load Metrics (119 ± 145 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
|
No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes old what's new items and prevents the What's New modal from displaying.
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist