Skip to content

fix (cherry-pick): Remove old What's New messages (#25048) for 12.0.0#25157

Merged
HowardBraham merged 2 commits intoVersion-v12.0.0from
Version-v12.0.0-cherry-pick-whats-new
Jun 12, 2024
Merged

fix (cherry-pick): Remove old What's New messages (#25048) for 12.0.0#25157
HowardBraham merged 2 commits intoVersion-v12.0.0from
Version-v12.0.0-cherry-pick-whats-new

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented Jun 7, 2024

Description

Removes old what's new items and prevents the What's New modal from displaying.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Open extension
  2. Don't see what's new

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

Removes legacy What's New messages, leaving only the Firefox WN *just*
so that we can keep the shape of data here. This PR ensures _no_ What's
New messages display at this time.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25048?quickstart=1)

## **Related issues**

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2613

## **Manual testing steps**

1. Install fresh MetaMask in Chrome
2. See no "What's New" items.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@darkwing darkwing requested a review from a team as a code owner June 7, 2024 22:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jun 10, 2024
@darkwing darkwing changed the base branch from develop to Version-v12.0.0 June 10, 2024 23:08
@darkwing darkwing force-pushed the Version-v12.0.0-cherry-pick-whats-new branch from ec3d93b to 183bb25 Compare June 10, 2024 23:09
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have full context of this PR but looking good left a couple comments:

  • Confirmed What's New Modal doesn't appear in fresh install of the extension ✅
  • Checked no instances of removed local keys from en remain ✅
  • Checked no instances of removed consts remain ❌

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [183bb25]
Page Load Metrics (138 ± 169 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6412589178
domContentLoaded9181221
load421672138352169
domInteractive9181221
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -1.09 KiB (-0.02%)
  • common: -6.35 KiB (-0.10%)

@danjm danjm changed the title cherry-pick: Remove old What's New messages (#25048) for 12.0.0 fix (cherry-pick): Remove old What's New messages (#25048) for 12.0.0 Jun 12, 2024
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

Copy link
Copy Markdown
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HowardBraham HowardBraham merged commit 4fc4bdb into Version-v12.0.0 Jun 12, 2024
@HowardBraham HowardBraham deleted the Version-v12.0.0-cherry-pick-whats-new branch June 12, 2024 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1ab073f]
Page Load Metrics (119 ± 145 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69166862110
domContentLoaded8191021
load431433119302145
domInteractive8181021
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 4.99 KiB (0.07%)
  • common: -3.04 KiB (-0.05%)

@metamaskbot metamaskbot added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 12, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-core-extension-ux Core Extension UX team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants