fix: Remove old What's New messages#25048
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
e24902d to
2685652
Compare
HowardBraham
reviewed
Jun 6, 2024
shared/notifications/index.ts
Outdated
Comment on lines
216
to
220
Contributor
There was a problem hiding this comment.
I think we can delete these two images?
2685652 to
93fae73
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25048 +/- ##
===========================================
- Coverage 65.45% 65.41% -0.05%
===========================================
Files 1352 1352
Lines 53971 53928 -43
Branches 14004 13997 -7
===========================================
- Hits 35326 35273 -53
- Misses 18645 18655 +10 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [1e94ca8]
Page Load Metrics (55 ± 5 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
9 tasks
darkwing
commented
Jun 6, 2024
| ]); | ||
|
|
||
| const TEMPORARY_DISABLE_WHATS_NEW = true; | ||
| const showWhatsNewPopup = TEMPORARY_DISABLE_WHATS_NEW |
Contributor
Author
There was a problem hiding this comment.
This ensures the What's New modal never displays.
jonybur
approved these changes
Jun 7, 2024
sahar-fehri
approved these changes
Jun 7, 2024
Collaborator
|
Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes legacy What's New messages, leaving only the Firefox WN just so that we can keep the shape of data here. This PR ensures no What's New messages display at this time.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2613
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist