Version v11.16.8 alternative - patch selected network controller#25127
Merged
Gudahtt merged 2 commits intoVersion-v11.16.8-alternativefrom Jun 7, 2024
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
approved these changes
Jun 7, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! I also reviewed the patch branch, and verified that the patch was applied correctly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v11.16.8-alternative #25127 +/- ##
=============================================================
Coverage 67.33% 67.33%
=============================================================
Files 1266 1266
Lines 49626 49626
Branches 12895 12895
=============================================================
Hits 33411 33411
Misses 16215 16215 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [a986c7a]
Page Load Metrics (71 ± 15 ms)
|
cryptotavares
approved these changes
Jun 7, 2024
Collaborator
|
No release label on PR. Adding release label release-11.16.8 on PR, as PR was cherry-picked in branch 11.16.8. |
Contributor
|
We need to port this patch onto the v12.0.0 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core PR: MetaMask/core#4388
Patch Branch: jl/patch-selected-network-controller-12.0.1-setNetworkClientId-guard