fix(cherry-pick): iframe injection in MV3 (#25051)#25056
Merged
danjm merged 1 commit intoVersion-v11.16.6from Jun 5, 2024
Merged
fix(cherry-pick): iframe injection in MV3 (#25051)#25056danjm merged 1 commit intoVersion-v11.16.6from
danjm merged 1 commit intoVersion-v11.16.6from
Conversation
## **Description** Fixes injection into iframes in the MV3 build by enabling `allFrames`. This is also currently enabled in MV2: https://github.com/MetaMask/metamask-extension/blob/13bd82914d1ac2c584fb799e6eee9b90fe889fe2/app/manifest/v2/_base.json#L42 [](https://codespaces.new/MetaMask/metamask-extension/pull/25051?quickstart=1) ## **Manual testing steps** 1. Go to https://jup.ag/ 2. Try connecting with MetaMask, this will use Solflare snap 3. You should be able to fully connect to the site
Collaborator
|
No release label on PR. Adding release label release-11.16.6 on PR, as PR was cherry-picked in branch 11.16.6. |
Collaborator
Builds ready [0e3b4ee]
Page Load Metrics (838 ± 575 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks 98385ff (#25051) to Version-v11.16.6