Skip to content

fix: iframe injection in MV3#25051

Merged
FrederikBolding merged 1 commit intodevelopfrom
fb/fix-iframe-injection-in-mv3
Jun 5, 2024
Merged

fix: iframe injection in MV3#25051
FrederikBolding merged 1 commit intodevelopfrom
fb/fix-iframe-injection-in-mv3

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Jun 5, 2024 •
edited by github-actions bot
Loading

Description

Fixes injection into iframes in the MV3 build by enabling allFrames. This is also currently enabled in MV2:

metamask-extension/app/manifest/v2/_base.json

Line 42 in 13bd829

"all_frames": true

Open in GitHub Codespaces

Manual testing steps

  1. Go to https://jup.ag/
  2. Try connecting with MetaMask, this will use Solflare snap
  3. You should be able to fully connect to the site

@FrederikBolding FrederikBolding added the team-extension-platform Extension Platform team label Jun 5, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner June 5, 2024 09:06
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 5, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.69%. Comparing base (13bd829) to head (486c137).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25051   +/-   ##
========================================
  Coverage    65.69%   65.69%           
========================================
  Files         1370     1370           
  Lines        54385    54385           
  Branches     14159    14159           
========================================
  Hits         35727    35727           
  Misses       18658    18658

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 98385ff into develop Jun 5, 2024
@FrederikBolding FrederikBolding deleted the fb/fix-iframe-injection-in-mv3 branch June 5, 2024 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.16.6 Issue or pull request that will be included in release 11.16.6 and removed release-11.18.0 labels Jun 5, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 5, 2024

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zone-live zone-live zone-live approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.6 Issue or pull request that will be included in release 11.16.6 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FrederikBolding @metamaskbot @zone-live @danjm