Skip to content

chore: adds to allowlist AccountsController:getSelectedAccount and other#24992

Merged
zone-live merged 2 commits intodevelopfrom
MMI-adds-missing-actions-from-allowlist
Jun 3, 2024
Merged

chore: adds to allowlist AccountsController:getSelectedAccount and other#24992
zone-live merged 2 commits intodevelopfrom
MMI-adds-missing-actions-from-allowlist

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented Jun 3, 2024 •
edited
Loading

Description

Adds to the MMI actions allow list:

AccountsController:getSelectedAccount
AccountsController:setSelectedAccount

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested a review from a team as a code owner June 3, 2024 10:34
@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Jun 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live requested a review from albertolive June 3, 2024 10:35
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 3, 2024

Builds ready [e1c8033]
Page Load Metrics (138 ± 175 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6910985105
domContentLoaded8131111
load421727138365175
domInteractive8131111

@zone-live zone-live merged commit cf417bb into develop Jun 3, 2024
@zone-live zone-live deleted the MMI-adds-missing-actions-from-allowlist branch June 3, 2024 14:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.16.8 Issue or pull request that will be included in release 11.16.8 and removed release-11.18.0 labels Jun 3, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 6, 2024

Missing release label release-11.16.8 on PR. Adding release label release-11.16.8 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.8.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vinistevam vinistevam vinistevam approved these changes

+1 more reviewer

@albertolive albertolive albertolive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mmi DEPRECATED: The product got sunset release-11.16.8 Issue or pull request that will be included in release 11.16.8

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zone-live @metamaskbot @albertolive @vinistevam