<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

We collect metric data for each phase of a transaction's lifecycle.
During one phase, we try to detect the type of asset being transacted.
This step was broken due to a missing `await`, so the asset type was
never identified. Additionally, the missing `await` meant that errors
were not being handled correctly, resulting in many junk Sentry error
events.

This seems to have been broken as part of a TypeScript refactor, in

that was added in #21330

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24770?quickstart=1)

Fixes #18300

TODO

I haven't reproduced any actual bug/missing metrics data from this yet,
but presumably we should see that and be able to test this. I discovered
this by looking into the Sentry error volume side-effect.

N/A

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Derek Brans <dbrans@gmail.com>