Decouple `MetaMetricsController` from `TxController` by OGPoyraz · Pull Request #21330 · MetaMask/metamask-extension

OGPoyraz · 2023-10-11T21:57:04Z

Description

With ongoing effort of TransactionController alignment between mobile and extension, this PR aims to decouple MetaMetricsController functions from TransactionController and targets to make MetaMetrics event triggers client specific.

Manual testing steps

No functional changes.

Related issues

Fixes https://github.com/MetaMask/MetaMask-planning/issues/1053

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2023-10-12T06:04:21Z

Builds ready [367c52d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1164 ± 375 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	148	106	16	8
		domContentLoaded	71	144	96	16	8
		load	84	1960	1164	782	375
		domInteractive	71	144	96	16	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.6 KiB (0.15%)
ui: -130 Bytes (-0.00%)
common: 0 Bytes (0.00%)

codecov · 2023-10-12T06:05:02Z

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (703f4ba) 68.54% compared to head (4d25595) 68.55%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21330   +/-   ##
========================================
  Coverage    68.54%   68.55%           
========================================
  Files         1030     1031    +1     
  Lines        41037    41136   +99     
  Branches     10968    10980   +12     
========================================
+ Hits         28128    28197   +69     
- Misses       12909    12939   +30

Files	Coverage Δ
...p/scripts/lib/createRPCMethodTrackingMiddleware.js	`66.92% <ø> (-1.79%)`	⬇️
app/scripts/lib/snap-keyring/metrics.ts	`4.55% <100.00%> (-13.64%)`	⬇️
shared/constants/metametrics.ts	`100.00% <ø> (ø)`
shared/constants/transaction.ts	`100.00% <ø> (ø)`
ui/store/actions.ts	`43.16% <ø> (ø)`
ui/hooks/useTransactionEventFragment.js	`75.00% <0.00%> (ø)`
app/scripts/controllers/transactions/index.js	`72.12% <0.00%> (-0.89%)`	⬇️
app/scripts/metamask-controller.js	`54.82% <83.33%> (+0.83%)`	⬆️
app/scripts/lib/transaction-metrics.ts	`70.12% <70.12%> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ui/hooks/useTransactionEventFragment.js

app/scripts/lib/transaction-metrics.ts

metamaskbot · 2023-10-12T08:16:48Z

Builds ready [32dffcb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1160 ± 373 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	139	100	15	7
		domContentLoaded	68	140	95	18	9
		load	79	1830	1160	778	373
		domInteractive	68	139	95	18	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.66 KiB (0.16%)
ui: -130 Bytes (-0.00%)
common: 0 Bytes (0.00%)

app/scripts/controllers/transactions/index.js

app/scripts/lib/transaction-metrics.ts

app/scripts/metamask-controller.js

app/scripts/lib/transaction-metrics.test.ts

ui/store/actions.ts

app/scripts/lib/transaction-metrics.ts

metamaskbot · 2023-10-16T13:03:46Z

Builds ready [c5cdb26]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1036 ± 411 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	142	106	19	9
		domContentLoaded	67	142	96	23	11
		load	80	2088	1036	855	411
		domInteractive	67	142	96	22	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.27 KiB (0.14%)
ui: -154 Bytes (-0.00%)
common: 0 Bytes (0.00%)

…ntFragment

… instead bind context as arg

metamaskbot · 2023-10-18T22:42:49Z

Builds ready [4d25595]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (818 ± 378 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	134	106	17	8
		domContentLoaded	67	161	96	23	11
		load	79	1818	818	787	378
		domInteractive	67	161	96	23	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.3 KiB (0.13%)
ui: -154 Bytes (-0.00%)
common: 0 Bytes (0.00%)

OGPoyraz added the team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead label Oct 11, 2023

OGPoyraz mentioned this pull request Oct 11, 2023

Decouple MetaMetrics controller calls from TransactionController #21292

Closed

14 tasks

OGPoyraz changed the title ~~Decouple MetaMetricsController from TxController~~ [WIP] Decouple MetaMetricsController from TxController Oct 11, 2023

OGPoyraz changed the title ~~[WIP] Decouple MetaMetricsController from TxController~~ Decouple MetaMetricsController from TxController Oct 12, 2023

OGPoyraz marked this pull request as ready for review October 12, 2023 07:28

OGPoyraz requested a review from a team as a code owner October 12, 2023 07:28

OGPoyraz commented Oct 12, 2023

View reviewed changes

ui/hooks/useTransactionEventFragment.js Outdated Show resolved Hide resolved

OGPoyraz requested a review from brad-decker October 12, 2023 07:38

OGPoyraz commented Oct 12, 2023

View reviewed changes

app/scripts/lib/transaction-metrics.ts Show resolved Hide resolved

OGPoyraz commented Oct 13, 2023

View reviewed changes

app/scripts/controllers/transactions/index.js Show resolved Hide resolved