chore: update swaps blockedList api url by micaelae · Pull Request #24837 · MetaMask/metamask-extension

micaelae · 2024-05-28T17:19:31Z

Description

This is a follow-up to the initial Swap+Send blocklist implementation. This change shifts traffic from swaps-api to token-api by changing the fetched blocklist API.

Related issues

Fixes: N/A

Manual testing steps

Attempting to swap+send 1 ETH to BNB should not be possible
Attempting to swap+send 1 BNB to ETH should not be possible
Network tab in dev console should show calls to the token-api blocklist endpoint, not swaps

Screenshots/Recordings

Blocklisting should function identically to the old behavior.

Before

N/A

After

N/A

Pre-merge author checklist

[X ] I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
[ X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

codecov · 2024-05-28T17:33:28Z

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.38%. Comparing base (af8ef25) to head (c11c05d).

❗ Current head c11c05d differs from pull request most recent head f56c452

Please upload reports for the commit f56c452 to get more accurate results.

Files	Patch %	Lines
shared/lib/swaps-utils.js	57.14%	3 Missing ⚠️
ui/ducks/send/send.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24837      +/-   ##
===========================================
- Coverage    65.67%   65.38%   -0.28%     
===========================================
  Files         1359     1352       -7     
  Lines        54015    53992      -23     
  Branches     14017    14016       -1     
===========================================
- Hits         35469    35301     -168     
- Misses       18546    18691     +145

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-03T20:36:42Z

Builds ready [8f63666]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (659 ± 481 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	136	101	16	8
		domContentLoaded	10	38	14	7	3
		load	63	2634	659	1002	481
		domInteractive	10	38	14	7	3

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 161 Bytes (0.00%)

metamaskbot · 2024-06-03T20:38:32Z

Builds ready [8f63666]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (659 ± 481 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	136	101	16	8
		domContentLoaded	10	38	14	7	3
		load	63	2634	659	1002	481
		domInteractive	10	38	14	7	3

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 161 Bytes (0.00%)

metamaskbot · 2024-06-03T21:49:11Z

Builds ready [3101731]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (115 ± 145 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	164	78	22	10
		domContentLoaded	8	14	10	1	1
		load	40	1432	115	302	145
		domInteractive	8	14	9	1	1

metamaskbot · 2024-06-04T18:50:49Z

Builds ready [1f0e90d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (49 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	119	81	11	5
		domContentLoaded	9	11	10	1	0
		load	42	80	49	9	4
		domInteractive	9	11	10	1	0

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 161 Bytes (0.00%)

shared/lib/swaps-utils.js

danjm

We will have to discuss the comment I made above tomorrow https://github.com/MetaMask/metamask-extension/pull/24837/files#r1626588451

metamaskbot · 2024-06-05T23:05:12Z

Builds ready [c11c05d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (48 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	99	77	9	4
		domContentLoaded	8	22	10	3	1
		load	40	73	48	8	4
		domInteractive	8	22	10	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 51 Bytes (0.00%)
common: 194 Bytes (0.00%)

…onality=false

metamaskbot · 2024-06-06T20:05:43Z

Builds ready [687d839]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (42 ± 1 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	85	74	6	3
		domContentLoaded	8	10	9	0	0
		load	41	48	42	1	1
		domInteractive	8	10	9	1	0

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 51 Bytes (0.00%)
common: 194 Bytes (0.00%)

micaelae added the release-11.18.0 label May 28, 2024

micaelae requested review from BZahory and ejwessel May 28, 2024 17:19

micaelae requested a review from a team as a code owner May 28, 2024 17:19

micaelae requested a review from a team as a code owner May 29, 2024 20:45

micaelae force-pushed the mb843-blocked-tokens-update branch from 8f63666 to 3101731 Compare June 3, 2024 20:55

ejwessel previously approved these changes Jun 3, 2024

View reviewed changes

BZahory previously approved these changes Jun 4, 2024

View reviewed changes

micaelae added the team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead label Jun 4, 2024

micaelae changed the title ~~[METABRIDGE-843] chore: update swaps blockedList api url~~ chore: update swaps blockedList api url Jun 4, 2024

micaelae force-pushed the mb843-blocked-tokens-update branch 2 times, most recently from c553f57 to 1f0e90d Compare June 4, 2024 18:14

danjm reviewed Jun 4, 2024

View reviewed changes

shared/lib/swaps-utils.js Show resolved Hide resolved

danjm suggested changes Jun 4, 2024

View reviewed changes

micaelae force-pushed the mb843-blocked-tokens-update branch 2 times, most recently from 04d9d5d to 2427c74 Compare June 5, 2024 21:04

micaelae dismissed stale reviews from BZahory and ejwessel via 8ad0f7d June 5, 2024 21:06

micaelae force-pushed the mb843-blocked-tokens-update branch from 8ad0f7d to c11c05d Compare June 5, 2024 22:19

BZahory previously approved these changes Jun 6, 2024

View reviewed changes

gauthierpetetin added release-12.0.0 Issue or pull request that will be included in release 12.0.0 and removed release-11.18.0 labels Jun 6, 2024

micaelae dismissed BZahory’s stale review via f56c452 June 6, 2024 17:27

BZahory approved these changes Jun 6, 2024

View reviewed changes

ejwessel approved these changes Jun 6, 2024

View reviewed changes

micaelae added 3 commits June 6, 2024 11:40

chore: update swaps blockedList api url

d7eefbe

chore: update privacy snapshot

7d11d4a

chore: block swaps setup and token blocklist calls when isBasicFuncti…

687d839

…onality=false

micaelae force-pushed the mb843-blocked-tokens-update branch from f56c452 to 687d839 Compare June 6, 2024 18:47

micaelae requested a review from danjm June 6, 2024 18:49

danjm approved these changes Jun 7, 2024

View reviewed changes

micaelae merged commit a2e6bcc into develop Jun 7, 2024

micaelae deleted the mb843-blocked-tokens-update branch June 7, 2024 17:33

github-actions bot locked and limited conversation to collaborators Jun 7, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update swaps blockedList api url#24837

chore: update swaps blockedList api url#24837
micaelae merged 3 commits intodevelopfrom
mb843-blocked-tokens-update

micaelae commented May 28, 2024 •

edited

Loading

Uh oh!

codecov bot commented May 28, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Jun 3, 2024

Uh oh!

metamaskbot commented Jun 3, 2024

Uh oh!

metamaskbot commented Jun 3, 2024

Uh oh!

metamaskbot commented Jun 4, 2024

Uh oh!

Uh oh!

danjm left a comment

Uh oh!

metamaskbot commented Jun 5, 2024

Uh oh!

metamaskbot commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

micaelae commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

codecov bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jun 3, 2024

Uh oh!

metamaskbot commented Jun 3, 2024

Uh oh!

metamaskbot commented Jun 3, 2024

Uh oh!

metamaskbot commented Jun 4, 2024

Uh oh!

Uh oh!

danjm left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jun 5, 2024

Uh oh!

metamaskbot commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

micaelae commented May 28, 2024 •

edited

Loading

codecov bot commented May 28, 2024 •

edited

Loading