[METABRIDGE-843] chore: disable blocked tokens#24591
Merged
micaelae merged 5 commits intomb843/updates-2from May 22, 2024
Merged
[METABRIDGE-843] chore: disable blocked tokens#24591micaelae merged 5 commits intomb843/updates-2from
micaelae merged 5 commits intomb843/updates-2from
Conversation
296ff78 to
91647ce
Compare
BZahory
reviewed
May 20, 2024
Contributor
|
You could update the |
f4d1d7f to
1573b19
Compare
BZahory
reviewed
May 20, 2024
Contributor
There was a problem hiding this comment.
Should we outright disable it? The current functionality shows the "send" option for both when "disabled"
1573b19 to
4c4b6a0
Compare
ejwessel
approved these changes
May 20, 2024
4c4b6a0 to
57d9a5f
Compare
Contributor
|
Still needs a tooltip for disabled dest |
BZahory
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
Related issues
Fixes: N/A
Manual testing steps
Go to send page, chainId=1
ETH -> BNB should not be possible
BNB -> BNB should be possible
BNB -> ETH should not be possible
BNB -> USDC should not be possible
BNB -> TKN should not be possible
Switch to a chain that's not supported by swaps
There should be no errors/crashes when attempting to do a simple send flow
Console/Network tab should have no errors regarding the blockedTokens api call
Screenshots/Recordings
Blocked dest tokens disabled:
Screen.Recording.2024-05-17.at.6.00.15.PM.mov
Disable swap+send when src token is blocked:
Pre-merge author checklist
Pre-merge reviewer checklist