Skip to content

Add tests for createDataDeletionRegulationTask#24816

Merged
Gudahtt merged 4 commits intodelete-metametrics-data-controllerfrom
delete-metametrics-data-controller-tests
Jun 3, 2024
Merged

Add tests for createDataDeletionRegulationTask#24816
Gudahtt merged 4 commits intodelete-metametrics-data-controllerfrom
delete-metametrics-data-controller-tests

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented May 28, 2024

Description

Add unit tests for the createDataDeletionRegulationTask method of DataDeletionService.

One of the two service methods is now fully tested. The remaining method will be tested in a later PR.

Open in GitHub Codespaces

Related issues

This is an improvement for the PR #24503

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt force-pushed the delete-metametrics-data-controller-tests branch 2 times, most recently from 958a652 to eb75eb5 Compare May 28, 2024 13:17
Base automatically changed from delete-metametrics-data-controller-add-service-configuration to delete-metametrics-data-controller May 28, 2024 16:31
@Gudahtt Gudahtt force-pushed the delete-metametrics-data-controller-tests branch 2 times, most recently from 6424d48 to d5d0c5a Compare May 29, 2024 12:46
One of the two service methods is now fully tested. The remaining method
will be tested in a later PR.
@Gudahtt Gudahtt force-pushed the delete-metametrics-data-controller-tests branch from d5d0c5a to 775b8e4 Compare May 29, 2024 12:47
@Gudahtt Gudahtt marked this pull request as ready for review May 29, 2024 12:48
@Gudahtt Gudahtt requested a review from a team as a code owner May 29, 2024 12:48
Gudahtt added 2 commits May 29, 2024 11:51
…er' into delete-metametrics-data-controller-tests

* origin/delete-metametrics-data-controller:
  refactor: Create dedicated services directory (#24863)
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Gudahtt Gudahtt merged commit 214cf30 into delete-metametrics-data-controller Jun 3, 2024
@Gudahtt Gudahtt deleted the delete-metametrics-data-controller-tests branch June 3, 2024 13:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants