Skip to content

refactor: Create dedicated services directory#24863

Merged
Gudahtt merged 1 commit intodelete-metametrics-data-controllerfrom
delete-metametrics-data-controller-move-service
May 29, 2024
Merged

refactor: Create dedicated services directory#24863
Gudahtt merged 1 commit intodelete-metametrics-data-controllerfrom
delete-metametrics-data-controller-move-service

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented May 29, 2024

Description

The DataDeletionService has been moved to a services directory, independent of controllers. This was done to reinforce that services are independent of controllers, and can be used outside of them.

Open in GitHub Codespaces

Related issues

This is an improvement for the PR #24503

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The `DataDeletionService` has been moved to a `services` directory,
independent of controllers. This was done to reinforce that services
are independent of controllers, and can be used outside of them.
@Gudahtt Gudahtt marked this pull request as ready for review May 29, 2024 12:57
@Gudahtt Gudahtt requested a review from a team as a code owner May 29, 2024 12:57
@Gudahtt Gudahtt merged commit d15ca11 into delete-metametrics-data-controller May 29, 2024
@Gudahtt Gudahtt deleted the delete-metametrics-data-controller-move-service branch May 29, 2024 14:16
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants