fix: flaky test onboarding @no-mmi doesn't make any network requests to infura before onboarding is completed/test-failure-screenshot.png and onboarding @no-mmi Clicks create a new wallet, accepts a secure password, reveals the Secret Recovery Phrase, confirm SRP/test-failure-screenshot.png#24813
Merged
fix: flaky test onboarding @no-mmi doesn't make any network requests to infura before onboarding is completed/test-failure-screenshot.png and onboarding @no-mmi Clicks create a new wallet, accepts a secure password, reveals the Secret Recovery Phrase, confirm SRP/test-failure-screenshot.png#24813
onboarding @no-mmi doesn't make any network requests to infura before onboarding is completed/test-failure-screenshot.png and onboarding @no-mmi Clicks create a new wallet, accepts a secure password, reveals the Secret Recovery Phrase, confirm SRP/test-failure-screenshot.png#24813Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [cc36a2b]
Page Load Metrics (728 ± 480 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
May 28, 2024
chloeYue
approved these changes
May 28, 2024
DDDDDanica
approved these changes
May 28, 2024
Collaborator
Builds ready [ca8a454]
Page Load Metrics (1230 ± 613 ms)
Bundle size diffs
|
Gudahtt
reviewed
May 28, 2024
| error.name === 'StaleElementReferenceError' && | ||
| attempt < retries - 1 | ||
| ) { | ||
| await this.driver.delay(1000); |
Member
There was a problem hiding this comment.
Was this what was intended?
await this.delay(1000);
I'm not seeing a delay function on the internal webdriver instance. I'm seeing a this.driver.delay is not a function error on various e2e jobs
Member
Author
There was a problem hiding this comment.
oops that is a great catch! indeed it should be this.delay()
Member
Author
There was a problem hiding this comment.
here is the fix
#24838
thank you v much Mark 🙏
Member
Author
There was a problem hiding this comment.
on the bright side, this means that this race-condition was happening quite often 😅
Collaborator
|
Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes more onboarding flakiness
onboarding @no-mmi doesn't make any network requests to infura before onboarding is completed/test-failure-screenshot.pnandonboarding @no-mmi Clicks create a new wallet, accepts a secure password, reveals the Secret Recovery Phrase, confirm SRP/test-failure-screenshot.png.The error is originated when we try to click an element which is in stale state
StaleElementReferenceError: stale element reference: stale element not found in the current frame.This is a race condition originated in the
clickElementmethod, in the following way:Extra note: this race condition is surfaced in the Onboarding tests mostly (I've only seen it fail there, so far), since I suspect that the the actions we perform there, all refresh the same react component for onboarding, giving a window for this casuistic to happen
Related issues
Fixes: #24602 (remaining items)
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist