Skip to content

fix: clickElement method retrial with this.delay instead of this.driver.delay#24838

Merged
seaona merged 1 commit intodevelopfrom
fix-driver-delay
May 28, 2024
Merged

fix: clickElement method retrial with this.delay instead of this.driver.delay#24838
seaona merged 1 commit intodevelopfrom
fix-driver-delay

Conversation

@seaona
Copy link
Copy Markdown
Member

@seaona seaona commented May 28, 2024 •
edited
Loading

Description

The clickElement method was enhanced to mitigate a race condition but mistakenly we called this.driver.delay instead of this.delay. This PR fixes the issue.

Context: https://github.com/MetaMask/metamask-extension/pull/24813/files#r1617677338
Found by @Gudahtt .

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona mentioned this pull request May 28, 2024
Merged
7 tasks
@seaona seaona marked this pull request as ready for review May 28, 2024 17:49
@seaona seaona requested a review from a team as a code owner May 28, 2024 17:49
Gudahtt
Gudahtt approved these changes May 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seaona
Copy link
Copy Markdown
Member Author

seaona commented May 28, 2024

thank you for the great catch @Gudahtt

@seaona seaona added the team-extension-platform Extension Platform team label May 28, 2024
@seaona seaona merged commit 60150f0 into develop May 28, 2024
@seaona seaona deleted the fix-driver-delay branch May 28, 2024 18:36
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 28, 2024

Builds ready [acfb1ca]
Page Load Metrics (912 ± 549 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint654351207837
domContentLoaded95417126
load5326999121144549
domInteractive95417126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added release-11.16.6 Issue or pull request that will be included in release 11.16.6 and removed release-11.18.0 labels Jun 4, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 4, 2024

Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@bergeron bergeron bergeron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.16.6 Issue or pull request that will be included in release 11.16.6 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seaona @metamaskbot @Gudahtt @bergeron