Skip to content

cherry-pick feat: disable stx opt-in modal (#24715) into v11.15.6#24720

Merged
danjm merged 1 commit intoVersion-v11.15.6from
Version-v11.15.6-disable-stx-opt-in-modal
May 22, 2024
Merged

cherry-pick feat: disable stx opt-in modal (#24715) into v11.15.6#24720
danjm merged 1 commit intoVersion-v11.15.6from
Version-v11.15.6-disable-stx-opt-in-modal

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented May 22, 2024

cherry-pick feat: disable stx opt-in modal 20e51e6 (#24715) into v11.15.6

no merge conflicts

To make sure the stx opt-in modal still pops up for users who install 11.15.6 and then update at a later time:
I followed these steps:

  1. Create a build off the cherry-pick branch (this PR). Install and onboard. Verify no modal is shown
  2. Create the revert of this PR
  3. Create a build off the revert branch
  4. Manually upgrade the build from step 1 to the build from step 3
  5. Open and unlock metamask, verify that the opt-in modal is shown

## **Description**
Temporarily disable the smart transactions opt-in modal to unblock the
11.15 rollout.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24715?quickstart=1)

## **Related issues**


## **Manual testing steps**


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans marked this pull request as ready for review May 22, 2024 18:17
@dbrans dbrans requested a review from a team as a code owner May 22, 2024 18:17
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 22, 2024
@danjm danjm merged commit 21863e4 into Version-v11.15.6 May 22, 2024
@danjm danjm deleted the Version-v11.15.6-disable-stx-opt-in-modal branch May 22, 2024 21:12
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@metamaskbot metamaskbot added the release-11.15.6 Issue or pull request that will be included in release 11.15.6 label May 22, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-11.15.6 on PR, as PR was cherry-picked in branch 11.15.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.15.6 Issue or pull request that will be included in release 11.15.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants